fdd86c1da2
avm2: avoid enqueuing Sound.play an infinite amount of times ( #17425 )
2024-08-13 15:57:22 +00:00
3b9d9cf230
avm2: Pass in `Gc<'gc, BytecodeMethod<'gc>>` to `optimize`
...
This allows us to pretty-print a method name from within
`optimize` using `display_function` (which needs to do
`Gc::ptr_eq`)
2024-08-12 21:23:33 -04:00
953c6732cc
Fix extra class flash.display
2024-08-12 18:05:56 -07:00
7ed2bdb8b6
avm2: Ignore debug opcodes when checking has_simple_scoping
...
Previously, swfs with debug opcodes would never be able to
use the `has_simple_scoping` optimization, since we would fail
to match the getlocal0/pushscope sequence.
We now allow any number of interleaved debug opcodes when checking
for this pattern.
2024-08-12 20:14:45 -04:00
79817f41d8
avm2: Add `[API("674")]` to Rectangle.copyFrom
...
This fixes old classes that extend Rectangle and define `copyFrom`
without marking it as an override
2024-08-12 19:36:47 -04:00
9239cb8a5d
chore: A couple typo fixes in comments here and there
2024-08-12 21:36:51 +02:00
f51dcf8d55
build(deps): bump the cargo-minor group with 8 updates
...
Bumps the cargo-minor group with 8 updates:
| Package | From | To |
| --- | --- | --- |
| [clap](https://github.com/clap-rs/clap ) | `4.5.13` | `4.5.15` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.204` | `1.0.206` |
| [linkme](https://github.com/dtolnay/linkme ) | `0.3.27` | `0.3.28` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.122` | `1.0.124` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.72` | `2.0.74` |
| [fontdb](https://github.com/RazrFalcon/fontdb ) | `0.20.0` | `0.21.0` |
| [async-io](https://github.com/smol-rs/async-io ) | `2.3.3` | `2.3.4` |
| [tempfile](https://github.com/Stebalien/tempfile ) | `3.11.0` | `3.12.0` |
Updates `clap` from 4.5.13 to 4.5.15
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/clap_complete-v4.5.13...v4.5.15 )
Updates `serde` from 1.0.204 to 1.0.206
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.204...v1.0.206 )
Updates `linkme` from 0.3.27 to 0.3.28
- [Release notes](https://github.com/dtolnay/linkme/releases )
- [Commits](https://github.com/dtolnay/linkme/compare/0.3.27...0.3.28 )
Updates `serde_json` from 1.0.122 to 1.0.124
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.122...v1.0.124 )
Updates `syn` from 2.0.72 to 2.0.74
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.72...2.0.74 )
Updates `fontdb` from 0.20.0 to 0.21.0
- [Changelog](https://github.com/RazrFalcon/fontdb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RazrFalcon/fontdb/compare/v0.20.0...v0.21.0 )
Updates `async-io` from 2.3.3 to 2.3.4
- [Release notes](https://github.com/smol-rs/async-io/releases )
- [Changelog](https://github.com/smol-rs/async-io/blob/master/CHANGELOG.md )
- [Commits](https://github.com/smol-rs/async-io/compare/v2.3.3...v2.3.4 )
Updates `tempfile` from 3.11.0 to 3.12.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/commits )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: linkme
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: fontdb
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: async-io
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-12 16:45:39 +02:00
bf55f15913
avm2: Declare 'namespace AS3' and validate bytecode in playerglobals
...
In order for asc.jar to generate efficient bytecode
(a direct 'callproperty' instead of a dynamic namespace and method
lookup), we need to have 'namespace AS3' in each package where we
do a qualified 'obj.AS3::SomeMethod()' call.
I've adjusted `build_playerglobal` to scan all of our playerglobal
method bodies to ensure that we don't have the bad bytecode.
This uncovered several places where we were missing `namespace AS3'
Before this change, we were creating a new bound method within
all of our prototype methods in `XML/XMLList`, since they used
'self.AS3::SomeXmlMethod()' calls to delegate to the AS3 native
method.
This saves several hundred megabytes on
`https://s1106-r2game-sq.7road.net `, since we no longer create
bound `FunctionObject`s for all of the distinct XML/XMLList objects
that the swf creates.
2024-08-11 17:33:46 -04:00
3b93ff941e
avm2: Intern XML node name
2024-08-11 09:56:02 +02:00
c3529afe11
avm1: Math tests: Substitute some trivial expected values and add TODOs about @epsilon
2024-08-11 02:15:36 +02:00
3573322c6d
avm1: Change expected values in `test_exp` math test to the exact ones returned by FP
...
And add some tolerance to make it pass with both current stable/beta and nightly rustc.
Thanks for figuring out the precise values, @kjarosh!
2024-08-11 02:15:36 +02:00
056501ee75
avm1: Add a way to specify numeric tolerance `@epsilon` when comparing in `test_method!`
2024-08-11 02:15:36 +02:00
47030b4f5b
core: remove UpdateContext's unused lifetime and reborrow method
2024-08-10 22:53:27 +02:00
13cffa4c94
core: appease clippy
2024-08-10 22:53:27 +02:00
d07437e30e
core: store 'gc borrows in UpdateContext, and `&mut UC` in Activation
...
This leaves the second UpdateContext lifetime unused and the `reborrow`
method useless, but they're kept to avoid an unnecessarily huge diff.
2024-08-10 22:53:27 +02:00
d116ef82e9
core: rework the way the garbage-collected arena is entered in `Player`
...
Add `Player::enter_arena(_mut)` methods, giving more ergonomic access to
the GC'd arena by:
- handling the RefCell borrows for you;
- passing an extra `&(mut) Player` parameter into the closure;
- giving all borrows the same `'gc` lifetime (thanks to strategic `unsafe`).
2024-08-10 22:53:27 +02:00
0b3395d21f
core: simplify callstack handling in Player
...
Grab the AVM2 callstack handle before constructing the GC root,
so that we can set it directly instead of modify the GC root once
constructed. This means we can remove an extra GcCell.
Also switch the callstack object from GcCell to GcRefLock.
2024-08-10 22:53:27 +02:00
0097aea381
avm2: Make primitive coercions way cheaper
2024-08-10 17:24:31 +02:00
f202088bd8
avm2: Box E4XNamespace in E4XNodeData
2024-08-10 15:28:28 +02:00
637b1ccf4e
avm2: Save an alloc when calling Regexp effective_replacement with no replacement patterns
2024-08-10 01:53:01 +02:00
0023062c82
avm2: Short circuit the regexp replacement logic if it's a simple (no pattern) string
2024-08-10 01:53:01 +02:00
ef42bba20c
avm2: Don't realloc the same string in Regexp.replace_with_fn, if no match was found
2024-08-10 01:53:01 +02:00
863e621bbb
avm2: Make ScriptObjectData.vtable non-Optional
2024-08-07 14:57:17 -07:00
fa4df53831
avm2: Change the alignment assertion to use `ScriptObjectData` instead of `RefLock<ScriptObjectData>`
2024-08-07 11:58:05 -07:00
732775d08a
avm2: Use interior mutability in `ScriptObjectData`
2024-08-07 11:58:05 -07:00
117df6e3c2
avm2: Resolve review notes in `enum_trait_object` macro
2024-08-06 19:25:03 -07:00
53347ed088
core: Remove unnecessary defined `#[no_dynamic]` `proc_macro_attribute`
2024-08-06 19:25:03 -07:00
c98c173c6b
chore: Run `cargo fix`
2024-08-06 19:25:03 -07:00
806da319c0
avm2: Ensure alignment between *ObjectData and ScriptObjectData is the same
2024-08-06 19:25:03 -07:00
9c399da94a
avm2: Add a `#[no_dynamic]` attribute to specify functions in `enum_trait_object` that don't need dynamic dispatch
2024-08-06 19:25:03 -07:00
e58a82289a
avm2: Remove some dynamic-dispatch TObject logic (both on Object variants and defined on TObject)
...
This results in better codegen for `Object::get_slot` and `set_slot`
2024-08-06 19:25:03 -07:00
6350f5cb87
avm1: made the context menu work for all avm1 objects
2024-08-06 22:11:17 +02:00
124310986f
render,desktop: Switch to `wgpu` `v22.1.0` and latest `egui` without `winit` 0.30
...
I opted to enable dithering in egui, because why not.
2024-08-06 15:00:38 +02:00
e618c6862b
build(deps): bump the cargo-minor group with 9 updates
...
Bumps the cargo-minor group with 9 updates:
| Package | From | To |
| --- | --- | --- |
| [clap](https://github.com/clap-rs/clap ) | `4.5.11` | `4.5.13` |
| [bytemuck](https://github.com/Lokathor/bytemuck ) | `1.16.1` | `1.16.3` |
| [flate2](https://github.com/rust-lang/flate2-rs ) | `1.0.30` | `1.0.31` |
| [indexmap](https://github.com/indexmap-rs/indexmap ) | `2.2.6` | `2.3.0` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.121` | `1.0.122` |
| [regex](https://github.com/rust-lang/regex ) | `1.10.5` | `1.10.6` |
| [zip](https://github.com/zip-rs/zip2 ) | `2.1.5` | `2.1.6` |
| [tempfile](https://github.com/Stebalien/tempfile ) | `3.10.1` | `3.11.0` |
| [lru](https://github.com/jeromefroe/lru-rs ) | `0.12.3` | `0.12.4` |
Updates `clap` from 4.5.11 to 4.5.13
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/clap_complete-v4.5.11...v4.5.13 )
Updates `bytemuck` from 1.16.1 to 1.16.3
- [Changelog](https://github.com/Lokathor/bytemuck/blob/main/changelog.md )
- [Commits](https://github.com/Lokathor/bytemuck/compare/v1.16.1...v1.16.3 )
Updates `flate2` from 1.0.30 to 1.0.31
- [Release notes](https://github.com/rust-lang/flate2-rs/releases )
- [Commits](https://github.com/rust-lang/flate2-rs/commits )
Updates `indexmap` from 2.2.6 to 2.3.0
- [Changelog](https://github.com/indexmap-rs/indexmap/blob/master/RELEASES.md )
- [Commits](https://github.com/indexmap-rs/indexmap/compare/2.2.6...2.3.0 )
Updates `serde_json` from 1.0.121 to 1.0.122
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.121...v1.0.122 )
Updates `regex` from 1.10.5 to 1.10.6
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.10.5...1.10.6 )
Updates `zip` from 2.1.5 to 2.1.6
- [Release notes](https://github.com/zip-rs/zip2/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zip-rs/zip2/compare/v2.1.5...v2.1.6 )
Updates `tempfile` from 3.10.1 to 3.11.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.10.1...v3.11.0 )
Updates `lru` from 0.12.3 to 0.12.4
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.12.3...0.12.4 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: bytemuck
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: flate2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: indexmap
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-05 17:49:09 +02:00
3b482b176e
chore: Update translations from Crowdin
2024-08-05 13:37:33 +02:00
85c7370577
text: Fix laying out empty text boxes
...
This patch fixes how empty text boxes are laid out.
The empty boxes are now added during line fixup, and not after,
which ensures they are subjected to alignment and other adjustments.
2024-08-02 17:56:45 +02:00
8722642ed7
text: Reset max font size on newline
...
Before this patch, max font size (which claimed to be the highest font
size observed within the current line) was calculated for each span,
regardless of newlines.
2024-08-02 17:56:45 +02:00
fcbeb92406
text: Assume there's at least one layout box
...
That condition related to drawing a cursor when there are no boxes is
outdated, as currently it's guaranteed that there's at least one box.
FormatSpans.normalize() ensures that there's at least one span, and
LayoutContext.fixup_line() ensures that each line has at least one box.
2024-08-02 17:56:45 +02:00
2de9fb83b4
text: Ignore non-text boxes when calculating line bounds
2024-08-02 17:07:02 +02:00
6c233ed859
avm2: Annotate all object *Data structs with `#[repr(C)]`
...
This ensures that the ScriptObjectData common to every *Data is always at the same offset, which results in better codegen for TObject methods
2024-08-01 09:09:29 -07:00
c54de07382
avm2: Resolve review comments and use `activation.gc()` in some places
2024-08-01 09:09:29 -07:00
8f6736da74
avm2: Store a `DisplayObject` instead of `Option<DisplayObject>` in `StageObject`
2024-08-01 09:09:29 -07:00
3ae53a6ef2
avm2: Use `Gc` instead of `GcCell` in `ScriptObject`
2024-08-01 09:09:29 -07:00
c80bd7a55e
avm2: Use `Gc` instead of `GcCell` in `FunctionObject`
2024-08-01 09:09:29 -07:00
336e10a535
avm2: Use `Gc` instead of `GcCell` in `XmlListObject`
2024-08-01 09:09:29 -07:00
2ff8238bf0
avm2: Remove now-unnecessary `Mutation` argument in some LoaderInfo methods
2024-08-01 09:09:29 -07:00
49188bd5d7
avm2: Use `Gc` instead of `GcCell` in `LoaderInfoObject`
2024-08-01 09:09:29 -07:00
fa759a06a4
avm2: Use `Gc` instead of `GcCell` in `EventObject`
2024-08-01 09:09:29 -07:00
5ea9b5d80b
avm2: Use `Gc` instead of `GcCell` in `SoundChannelObject`
2024-08-01 09:09:29 -07:00
458264a76a
avm2: Use `Gc` instead of `GcCell` in `SoundObject`
2024-08-01 09:09:29 -07:00
Marco Bartoli