5dcb87c727
debug_ui: Add stage focus rect
2024-05-13 20:48:48 +02:00
f713c90cca
core: Add possibility to set tab_enabled in AVM1
...
This makes it possible to set it from the debug UI.
2024-05-13 20:48:48 +02:00
0c3ab81671
debug_ui: Fix a positioning issue in Stage tab
2024-05-13 20:48:48 +02:00
a5b7933c26
debug_ui: Add a tab for interactive objects
2024-05-13 20:48:48 +02:00
4253525f8b
core: Add InteractiveObject.tab_enabled_default
...
This patch removes two methods:
* `tab_enabled_avm1`, and
* `tab_enabled_avm2_default`,
and replaces them with `tab_enabled_default`.
This refactor makes the code more readable and simple.
2024-05-13 20:48:48 +02:00
819abe8420
build(deps): bump the cargo-minor group with 14 updates
...
Bumps the cargo-minor group with 14 updates:
| Package | From | To |
| --- | --- | --- |
| [async-channel](https://github.com/smol-rs/async-channel ) | `2.2.1` | `2.3.0` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.200` | `1.0.201` |
| [thiserror](https://github.com/dtolnay/thiserror ) | `1.0.59` | `1.0.60` |
| [linkme](https://github.com/dtolnay/linkme ) | `0.3.25` | `0.3.26` |
| [bitstream-io](https://github.com/tuffy/bitstream-io ) | `2.2.0` | `2.3.0` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.116` | `1.0.117` |
| [ttf-parser](https://github.com/RazrFalcon/ttf-parser ) | `0.20.0` | `0.21.1` |
| [num-bigint](https://github.com/rust-num/num-bigint ) | `0.4.4` | `0.4.5` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.60` | `2.0.63` |
| [proc-macro2](https://github.com/dtolnay/proc-macro2 ) | `1.0.81` | `1.0.82` |
| [fontdb](https://github.com/RazrFalcon/fontdb ) | `0.16.2` | `0.17.0` |
| [unic-langid](https://github.com/zbraniecki/unic-locale ) | `0.9.4` | `0.9.5` |
| [zip](https://github.com/zip-rs/zip2 ) | `1.2.0` | `1.2.3` |
| [libtest-mimic](https://github.com/LukasKalbertodt/libtest-mimic ) | `0.7.2` | `0.7.3` |
Updates `async-channel` from 2.2.1 to 2.3.0
- [Release notes](https://github.com/smol-rs/async-channel/releases )
- [Changelog](https://github.com/smol-rs/async-channel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/smol-rs/async-channel/compare/v2.2.1...v2.3.0 )
Updates `serde` from 1.0.200 to 1.0.201
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.200...v1.0.201 )
Updates `thiserror` from 1.0.59 to 1.0.60
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.59...1.0.60 )
Updates `linkme` from 0.3.25 to 0.3.26
- [Release notes](https://github.com/dtolnay/linkme/releases )
- [Commits](https://github.com/dtolnay/linkme/compare/0.3.25...0.3.26 )
Updates `bitstream-io` from 2.2.0 to 2.3.0
- [Commits](https://github.com/tuffy/bitstream-io/compare/v2.2.0...v2.3.0 )
Updates `serde_json` from 1.0.116 to 1.0.117
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.116...v1.0.117 )
Updates `ttf-parser` from 0.20.0 to 0.21.1
- [Changelog](https://github.com/RazrFalcon/ttf-parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RazrFalcon/ttf-parser/compare/v0.20.0...v0.21.1 )
Updates `num-bigint` from 0.4.4 to 0.4.5
- [Changelog](https://github.com/rust-num/num-bigint/blob/master/RELEASES.md )
- [Commits](https://github.com/rust-num/num-bigint/compare/num-bigint-0.4.4...num-bigint-0.4.5 )
Updates `syn` from 2.0.60 to 2.0.63
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.60...2.0.63 )
Updates `proc-macro2` from 1.0.81 to 1.0.82
- [Release notes](https://github.com/dtolnay/proc-macro2/releases )
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.81...1.0.82 )
Updates `fontdb` from 0.16.2 to 0.17.0
- [Changelog](https://github.com/RazrFalcon/fontdb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RazrFalcon/fontdb/compare/v0.16.2...v0.17.0 )
Updates `unic-langid` from 0.9.4 to 0.9.5
- [Release notes](https://github.com/zbraniecki/unic-locale/releases )
- [Commits](https://github.com/zbraniecki/unic-locale/commits )
Updates `zip` from 1.2.0 to 1.2.3
- [Release notes](https://github.com/zip-rs/zip2/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zip-rs/zip2/compare/v1.2.0...v1.2.3 )
Updates `libtest-mimic` from 0.7.2 to 0.7.3
- [Release notes](https://github.com/LukasKalbertodt/libtest-mimic/releases )
- [Changelog](https://github.com/LukasKalbertodt/libtest-mimic/blob/master/CHANGELOG.md )
- [Commits](https://github.com/LukasKalbertodt/libtest-mimic/compare/v0.7.2...v0.7.3 )
---
updated-dependencies:
- dependency-name: async-channel
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: linkme
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: bitstream-io
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: ttf-parser
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: num-bigint
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: fontdb
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: unic-langid
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: libtest-mimic
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-05-13 15:49:29 +02:00
272c07ea3b
avm2: Implement `describeType(null)` stub ( #16235 )
2024-05-10 22:06:56 +00:00
b1b7ccfbd2
avm1: Highlight buttons using their hit bounds
...
Buttons are always highlighted using their hit bounds.
I guess it does have some sense to it, because their bounds
usually change on hover (children are swapped out),
which would cause the automatic tab order to change during tabbing.
That could potentially create a loop in the tab ordering
(soft locking the tab).
2024-05-10 23:52:01 +02:00
1e5439ab68
core: Add InteractiveObject.highlight_bounds() method
...
This method returns the world bounds of
the focus highlight for the interactive object.
2024-05-10 23:52:01 +02:00
da9c9527e5
core: Allow pressing buttons with keyboard
...
This patch allows the keyboard to be used (Enter/Space) to press buttons.
2024-05-10 22:42:03 +02:00
18d9035685
core: Fire button event handlers only when highlight is active
...
It seems that button event handlers not only require focus to be fired,
but also an active highlight.
2024-05-10 22:42:03 +02:00
97a454cc36
core: Refactor a common condition to should_fire_button_event_handlers
...
This condition is identical for buttons and movie clips.
2024-05-10 22:42:03 +02:00
bfb7e57277
debug_ui: Improve highlight display, add re-focus button
...
Since highlight has 3 states now, it's better represented by
describing the state instead of having a checkbox.
A re-focus button has been added to compensate for the fact
that the highlight cannot be automatically enabled anymore.
2024-05-10 22:42:03 +02:00
df714d35bd
core: Differentiate between active and visible highlight
...
Some button events (e.g. KeyUp/KeyDown) seem to require a state when
the highlight is not visible, but is active (i.e. a focus is selected).
That is why this patch introduces a third possible state of
the highlight: ActiveHidden.
2024-05-10 22:42:03 +02:00
11c1120364
core: Invalidate cached bitmap on every newly decoded video frame
...
Not just when seeking manually. And request rendering to be sure.
2024-05-10 09:56:47 +02:00
8eaede1c2c
avm2: Try to speed up domain memory ops
2024-05-09 16:41:12 -07:00
8ab19054aa
avm2: Create bad branch errors lazily in verifier
2024-05-09 16:41:12 -07:00
4df7722aab
avm2: Add fast path for setting array property
2024-05-09 16:41:12 -07:00
ed037214b1
core: Always fire KeyPress after KeyDown for buttons
...
Button events are actually handled twofold:
1. KeyPress for printable characters is handled on TextInput,
2. KeyPress for special characters (e.g. enter, arrows)
is handled on KeyDown.
Before this patch, KeyPress was fired too early, so that for
special characters (2) it fired BEFORE KeyDown.
This was not a problem for printable characters, as they
fired on TextInput, which always fired separately after KeyDown.
This patch ensures that KeyPress is fired always in the proper order.
2024-05-09 21:13:13 +02:00
5541daa105
debug_ui: Add interactive tab order list
2024-05-09 20:57:53 +02:00
baa87ff016
core: Add FocusTracker::tab_order method
...
This method returns the current tab order as a list of objects.
2024-05-09 20:57:53 +02:00
ccf6b3edb5
debug_ui: Add possibility to clear current focus
2024-05-09 20:57:53 +02:00
ab62b740a7
debug_ui: Use open_display_object_button for focus
2024-05-09 20:57:53 +02:00
4e39598da4
debug_ui: Exclude hidden objects properly when searching
...
The option "Include Hidden" was not working properly,
as it did not exclude all hidden objects when disabled.
An object is hidden also when its ancestor is not visible.
2024-05-09 08:12:59 -07:00
ece156e478
core: Use draw_rect_outline for focus highlight
...
This ensures that highlight does not become outdated
(e.g. when the highlighted content moves).
Additionally, it makes the highlight have 3px independently of zoom.
2024-05-09 00:40:25 +02:00
07bfa0c3e2
core: Use draw_rect_outline for debug rects
...
This improves debug rect rendering so that debug rects
do not have missing corners as before.
2024-05-09 00:40:25 +02:00
eabf76dae8
core: Add RenderContext::draw_rect_outline
...
This method may be used to efficiently draw a simple rectangle outline
for debug rects and focus rects.
2024-05-09 00:40:25 +02:00
bc4ed4c5a1
core: Improve performance of round_to_even
...
This patch improves performance of ecma_conversions::round_to_even():
1. by using f64::round_ties_even(), which has been stable
since 1.77.0, instead of a custom algorithm; and
2. by removing an unnecessary comparison to i32::MIN,
as casting a float to an integer automatically saturates
values smaller than the minimum integer value to the minimum
value of the integer type.
2024-05-08 22:16:40 +02:00
8eaf844cdc
core: Add tests for round_to_even
2024-05-08 22:16:40 +02:00
b551d14a59
avm2: Ensure the focus is dropped when it's removed
...
The logic of dropping the focus when it's removed
applies not only to TextFields but for every InteractiveObject.
This patch ensures that any focus is dropped when its parent is removed.
2024-05-07 22:56:25 +02:00
428688e7e7
core: Add DisplayObject.on_parent_removed method
...
This method prevents code duplication performed when overwriting
set_parent to inject some behavior when the parent is removed.
2024-05-07 22:56:25 +02:00
8d50d1fead
core: Move has_focus to InteractiveObject
...
All the interactive objects had the has_focus flag in their concrete
implementations (even AVM2 button, which did not use it at all).
This patch moves it to InteractiveObject (as a bit flag), making it
easier to manage and use through the has_focus, set_has_focus methods.
Additionally, the operation of setting the current focus to None
when an object was having it was popular enough that it warranted its
own method of drop_focus.
2024-05-07 22:56:25 +02:00
120bfa2b30
avm2: Send ADDED_TO_STAGE in SimpleButton at correct time
2024-05-07 22:42:52 +02:00
8e6e71b2f7
web: Download the file on FileReference.save
...
This patch adds support for saving files on web using FileReference.
When writing data, a download is triggered with the default file name.
Currently, there's no dialog that lets the user select save destination.
This patch also ensures that all implementations of FileDialogResult
behave the same way: desktop, web, and tests.
The methods `write` and `refresh` have been merged into one:
`write_and_refresh`, which allows the tests and web implementations
behave the same way as desktop.
2024-05-07 22:26:30 +02:00
64df0368fd
avm2: Fix TextField.selectedText
2024-05-06 22:17:41 +02:00
901a88db29
avm2: Implement selectedText in class flash.text.TextField
2024-05-06 22:17:41 +02:00
0c38cc9e28
avm2: share binding skip optimization with `call_method`
2024-05-06 22:02:45 +02:00
0910df8307
avm2: Implement XML.contains ( #16206 )
...
* avm2: XML.contains() implemented
* tests: XMLList known_failure removed
* avm2: XML manual checks removed
* avm2: XMLList.contains() behavior fixed
* avm2: XML contains method moved to xml.rs
* avm2: Empty line removed in xml.rs
* avm2: XML contains args name renamed to value
2024-05-06 17:40:03 +00:00
42c26f61d1
core: Call focus handlers on every object
...
Before this patch, focus handlers were called from on_focus_changed,
only for selected objects. It seems that they should be called for
every object by default.
2024-05-04 17:05:24 -07:00
f5a0751557
avm2: Do not highlight Stage on focus
...
Stage is never highlightable, even if there's a focus on it.
2024-05-04 17:05:24 -07:00
aa006f0e8f
chore: Update translations from Crowdin
2024-05-02 18:07:40 +02:00
8ee514e62f
avm2: Handle setting tabIndex to -1
...
Despite throwing an error that `tabIndex` cannot be negative,
the value of -1 is allowed, and it means that `tabIndex` is unset.
2024-04-30 14:23:45 +02:00
f40cb6435f
code: Unset tabIndex upon assigning -1
...
The value of -1 for tabIndex always means that it's unset,
even in AVM1 where tabIndex may have a value of `undefined`.
2024-04-30 14:23:45 +02:00
054d0aab29
chore: Update translations from Crowdin
2024-04-30 01:14:39 +02:00
ec2aaa0549
avm2: Implement InteractiveObject.focusRect
2024-04-29 23:41:40 +02:00
6191984dd6
build(deps): bump the cargo-minor group with 4 updates
...
Bumps the cargo-minor group with 4 updates: [flate2](https://github.com/rust-lang/flate2-rs ), [hashbrown](https://github.com/rust-lang/hashbrown ), [gilrs](https://gitlab.com/gilrs-project/gilrs ) and [zip](https://github.com/Pr0methean/zip ).
Updates `flate2` from 1.0.29 to 1.0.30
- [Release notes](https://github.com/rust-lang/flate2-rs/releases )
- [Commits](https://github.com/rust-lang/flate2-rs/compare/1.0.29...1.0.30 )
Updates `hashbrown` from 0.14.3 to 0.14.5
- [Changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/hashbrown/compare/v0.14.3...v0.14.5 )
Updates `gilrs` from 0.10.6 to 0.10.7
- [Commits](https://gitlab.com/gilrs-project/gilrs/compare/v0.10.6...v0.10.7 )
Updates `zip` from 1.1.1 to 1.1.2
- [Release notes](https://github.com/Pr0methean/zip/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Pr0methean/zip/compare/1.1.1...v1.1.2 )
---
updated-dependencies:
- dependency-name: flate2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: hashbrown
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: gilrs
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 23:18:44 +02:00
0479259fb9
avm2: Implement DisplayObjectContainer.tabChildren
2024-04-29 21:54:06 +02:00
e3bc63f2bf
core: Add possibility to set tab_children for containers
2024-04-29 21:54:06 +02:00
39b6c9d096
avm2: Implement InteractiveObject.tabEnabled
2024-04-29 21:54:06 +02:00
1ecdaea392
avm2: Implement InteractiveObject.tabIndex
2024-04-29 21:54:06 +02:00
Kamil Jarosz