0a513f273e
avm2: Cleanup some Value::Object matching
2024-06-24 16:36:25 +02:00
04dfd1f22f
avm2: Do not fire roll over events on focus change (yet)
...
This patch bypasses AVM2 conditionally when firing roll over events
triggered by a focus change until a proper support for AVM2 events
is implemented.
2024-06-23 13:30:27 +02:00
9271618185
avm2: Properly import stub_getter and stub_setter in Shader
2024-06-22 13:28:01 -07:00
dc03f541db
avm2: Match Flash behavior for DoAbc/SymbolClass script initializers
...
Flash Player handles SymbolClass tags and eager (non-lazy) DoAbc2 tags in an unusual way:
During the first time that a given frame is executed:
1. All SymbolClass tags are processed in order, triggering ClassObject loading (and the associated
script initializer execution, if it hasn't already been run)
2. All eager (non-lazy) DoAbc/DoAbc2 tags have their *final* script initializer executed.
To implement this, we now cache the needed `Script` and symbol class
data during preloading. The first time we execute a frame, we run
the symbolclass class lookup and assignment, followed by the final
script initializer for each DoAbc2 tag in the frame.
This fixes 'minidash' (and probably other crossbridge games as well).
2024-06-21 16:57:06 +02:00
adea7ae743
text: Refactor EditText.line_text
...
This refactor takes advantage of the
new layout structure to simplify code.
2024-06-21 16:41:56 +02:00
bfbd2dbd19
text: Refactor EditText.layout_metrics
...
This refactor takes advantage of the
new layout structure to simplify code.
2024-06-21 16:41:56 +02:00
50ade23779
text: Implement Layout.bounds
2024-06-21 16:41:56 +02:00
ba13386788
text: Restructure layout to include text lines
...
This patch removes `LineData` & `get_line_data` and incorporates
their logic into layout calculation adding `Layout` and `LayoutLine`.
The goal is to simplify operations on the layout, as now
line data is always present and integrated with the layout.
Specialized methods may be added to `Layout` and `LayoutLine`
in the future.
2024-06-21 16:41:56 +02:00
d2f5b78503
text: Move lower_from_text_spans to module level
2024-06-21 16:41:56 +02:00
1164dd747a
avm2: Merge locals better
2024-06-20 17:02:13 -07:00
1389f5fa67
avm2: Record all jump sources in verifier
2024-06-20 17:02:13 -07:00
8b2c9d8157
avm2: Add stub for winding behavior of drawing triangles in Graphics
...
Currently, even-odd winding rule is used to render triangles,
but FP uses non-zero.
2024-06-19 23:24:55 +02:00
14ac29e435
avm2: Handle wrong number of coords when drawing triangles in Graphics
...
FP throws an error when the number of coordinates is odd for the indexed
version, and when is not divisible by 6 for the non-indexed version.
2024-06-19 23:24:55 +02:00
86a3086808
avm2: Fix errors thrown when culling has wrong value in Graphics
...
The errors differ between Graphics.drawTriangles and GraphicsTrianglePath.
The former throws 2004, whereas the latter throws 2008.
2024-06-19 23:24:55 +02:00
64acc7b3ad
avm2: Ignore out of range and non-integer triangle indices in Graphics
...
This behavior imitates FP's behavior.
2024-06-19 23:24:55 +02:00
2b9289e1b2
avm2: Implement culling for drawing triangles in Graphics
2024-06-19 23:24:55 +02:00
4993d70594
avm2: Unify drawing triangles in graphics.rs
...
There were two implementations for drawing triangles: one for
Graphics.drawTriangles, and the other for GraphicsTrianglePath.
However, they behave almost identically, so this patch uses
draw_triangles_internal for both.
2024-06-19 23:24:55 +02:00
9e1248d130
avm2: Add make_error_1125
2024-06-19 23:24:55 +02:00
4d12e0e5b4
core: Implement LocalConnection
2024-06-19 21:54:25 +02:00
0f534c837f
avm2: Improve drawing paths in Graphics
...
This patch improves drawing paths in Graphics:
* no error is thrown when there are 0 commands,
* no error is thrown when there are missing data points,
* an error is thrown when the number of coordinates is odd,
* no error is thrown and command processing is stopped
when an unknown command is encountered,
* the vector with parsed commands is removed, as it's not needed.
2024-06-19 20:58:33 +02:00
fae1500cc6
avm2: Add make_error_2004
2024-06-19 20:58:33 +02:00
687e049dc1
debug_ui: Add option to draw layout boxes for EditText
2024-06-19 20:12:43 +02:00
35f5227e2d
core,desktop: Update `wgpu` to `v0.20.1`, bump `egui`
2024-06-18 23:10:43 +02:00
9c8e4d7dce
core: Remove `DataFormat` for `URLLoader` loads since we can just check the string field
...
Also, don't set the data as variables if there is no data to set.
2024-06-18 20:56:50 +02:00
7a1ee0e109
core: `URLLoader` should check the data format after loading finishes, not when starting a load
2024-06-18 20:56:50 +02:00
a731b82b54
chore: Update translations from Crowdin
2024-06-17 14:57:20 +02:00
cacfb5a6a4
avm2: Fix and unify converting SWF's 1-based to 0-based slot indexing
2024-06-16 16:11:17 -07:00
4463a69c87
avm2: Implement namespace support for flash.xml
2024-06-15 22:26:57 +02:00
8fb214ea71
chore: Update translations from Crowdin
2024-06-14 22:41:19 +02:00
18c50df838
avm2: Don't get the `Class` class by using `instance_of` in `into_finished_class`
2024-06-13 23:49:52 +02:00
1705870951
avm2: Class initializers will be called twice when constructing two `ClassObject`s for one `Class`
2024-06-13 23:49:52 +02:00
7e7032d908
avm2: Remove `constructor`, `native_constructor`, and `call_handler` fields from `ClassObject`
...
They were already present on `Class`
2024-06-13 23:49:52 +02:00
52404bc3aa
build(deps): bump the cargo-minor group with 6 updates
...
Bumps the cargo-minor group with 6 updates:
| Package | From | To |
| --- | --- | --- |
| [clap](https://github.com/clap-rs/clap ) | `4.5.4` | `4.5.7` |
| [url](https://github.com/servo/rust-url ) | `2.5.0` | `2.5.1` |
| [linkme](https://github.com/dtolnay/linkme ) | `0.3.26` | `0.3.27` |
| [regex](https://github.com/rust-lang/regex ) | `1.10.4` | `1.10.5` |
| [zip](https://github.com/zip-rs/zip2 ) | `2.1.2` | `2.1.3` |
Updates `clap` from 4.5.4 to 4.5.7
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/clap_complete-v4.5.4...v4.5.7 )
Updates `url` from 2.5.0 to 2.5.1
- [Release notes](https://github.com/servo/rust-url/releases )
- [Commits](https://github.com/servo/rust-url/compare/v2.5.0...v2.5.1 )
Updates `linkme` from 0.3.26 to 0.3.27
- [Release notes](https://github.com/dtolnay/linkme/releases )
- [Commits](https://github.com/dtolnay/linkme/compare/0.3.26...0.3.27 )
Updates `regex` from 1.10.4 to 1.10.5
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.10.4...1.10.5 )
Updates `zip` from 2.1.2 to 2.1.3
- [Release notes](https://github.com/zip-rs/zip2/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zip-rs/zip2/compare/v2.1.2...v2.1.3 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: url
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: linkme
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: quick-xml
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-06-13 01:05:26 +02:00
4fa5853f88
chore: Update translations from Crowdin
2024-06-13 00:44:49 +02:00
c9b111996f
web: Make serde (more-)optional in core
2024-06-13 00:22:33 +02:00
e8dbd58306
core: Use DisplayObject.movie() instead of context.swf where applicable
...
This prevents problems in case of mixed-AVM content.
2024-06-13 00:06:10 +02:00
39e8a15db5
core: Update focus after handling press, not before
...
Updating focus before handling press caused onRollOut
to be fired before onPress, but it should be fired after.
2024-06-12 23:49:06 +02:00
516c56db15
chore: Suppress a `clippy::doc_lazy_continuation` beta lint false positive
2024-06-12 23:09:39 +02:00
0d25b5dba8
chore: Fix `clippy::needless_borrows_for_generic_args` beta lint
2024-06-12 22:42:18 +02:00
6b4ee7dfde
chore: Fix most `clippy::doc_lazy_continuation` beta lints
2024-06-12 22:42:18 +02:00
0e062c4b9b
avm2: Replace two more uses of `instance_of` with `instance_class`
2024-06-12 19:46:32 +02:00
97f75cc0b4
avm2: Move interface logic from `ClassObject` to `Class`
2024-06-12 19:46:32 +02:00
90c370d61b
avm2: Always store a Class on vtable
2024-06-12 19:46:32 +02:00
2c9028d2f9
avm2: Replace most uses of `instance_of` with `instance_class`
...
Also store a Class -> alias mapping instead of a ClassObject -> alias mapping for AMF.
2024-06-12 19:46:32 +02:00
3b9bb3f5db
chore: Update translations from Crowdin
2024-06-10 00:02:16 +02:00
bc85638920
avm2: Port registerClassAlias logic to Rust
2024-06-09 09:14:20 -07:00
142fc1d232
core: Prevent copying and cutting text from a password field
2024-06-09 15:38:35 +02:00
c23ec0782a
core: Prevent pasting empty string when the clipboard is empty
2024-06-09 15:38:35 +02:00
a2751c3c0f
core: Add English translations for copy/paste context menu
2024-06-09 15:38:35 +02:00
6117c3c68e
core: Add copy/paste context menu for EditText
...
This menu is shown when the EditText is focused and the mouse hovers over it.
It has the following elements, which may be disabled
when e.g. the field is not editable / selectable:
* Cut,
* Copy,
* Paste,
* Delete,
* Select All.
2024-06-09 15:38:35 +02:00
0910104c3b
core: Add EditText::is_text_control_applicable
...
This method is useful for checking whether the given text control code
may be applied to the current state of the EditText.
2024-06-09 15:38:35 +02:00
1f3c230691
core: Pass UpdateContext to ContextMenuState::build_builtin_items
...
This simplifies code, as we do not have to access
the same elements over and over.
2024-06-09 15:38:35 +02:00
2955add845
avm2: In Array.sortOn, behave better in presence of nonsense args
2024-06-09 11:11:57 +02:00
1d1eb6c966
avm2: Fix `NewClass` not popping the base class and better null propagation in optimizer
2024-06-08 14:25:43 -07:00
bb7a315afd
avm2: Misc. optimizer improvements
2024-06-08 14:25:43 -07:00
70fca6fa0a
web: Add create_audio to builder
2024-06-08 08:42:04 +02:00
3fa8735e97
web: Don't parse config in Rust, do it in Typescript with some tests
2024-06-08 08:42:04 +02:00
6e53f98068
avm2: Fix performance regression
...
A `ScriptObject` was being allocated on every `call_method` call
2024-06-08 00:31:29 +02:00
2704e1f506
core: Implement setting tabChildren for AVM1 for debug UI
2024-06-08 00:12:53 +02:00
b43f23ce9a
core: Move a tabChildren-related comment to the proper place
2024-06-08 00:12:53 +02:00
191e879172
avm2: Properly implement Stage.tabChildren
...
Stage.tabChildren does not modify the value of tabChildren of the stage,
but rather sets the tabChildren of the root movie.
2024-06-08 00:12:53 +02:00
da80f6d76e
debug_ui: Add "Tab children enabled"
2024-06-08 00:12:53 +02:00
c1ace7edc7
avm2: Use an empty string as the prefix for xmlns=
2024-06-06 20:14:40 +02:00
c3ad08c810
avm1: Treat MovieClip.createTextField params as integers
...
The parameters x,y,width,height of MovieClip.createTextField
should be integers.
2024-06-06 17:08:52 +02:00
5c89dd8374
avm2: Make the root movie non-highlightable
2024-06-05 02:08:13 +02:00
c51f13e4e4
debug_ui: Add "Is Root" to Display tab
2024-06-05 02:08:13 +02:00
348cb6ea6d
core: Remove unnecessary SWF version check in is_focusable
...
This check is unnecessary as is_focusable is only used in AVM1.
2024-06-05 02:08:13 +02:00
d39c7339d9
avm1: Make the root movie clip non-focusable and non-tabbable
...
Root movie clip should be neither focusable, nor tabbable.
2024-06-05 02:08:13 +02:00
488fc4ae9f
avm2: `Script` doesn't need to be borrowed
2024-06-04 15:31:14 -07:00
6acfc3953a
avm2: Slightly improve findprop optimizations when property is found on script
2024-06-04 15:31:14 -07:00
b523ad4b32
avm2: Fix a typo
2024-06-04 15:31:14 -07:00
ad2c5c547e
avm2: Cleanup optimizer
2024-06-04 15:31:14 -07:00
150d9d8bca
avm2: Implement `flash.text.IME` package
2024-06-04 15:31:14 -07:00
43549ab1d7
avm2: Add a vtable to Class, support getting vtable of static methods in optimizer
2024-06-04 15:31:14 -07:00
516e10ae26
avm1: Drop focus on EditText when something else is clicked
...
In AVM1 text fields are somewhat special when handling focus.
When a text field is clicked, it gains focus,
when something else is clicked, it loses the focus.
However, this logic only applies to text fields, other objects
(buttons, movie clips) neither gain focus nor lose it upon press.
2024-06-04 19:39:20 +02:00
b6612e8f83
avm2: Support namespaces in XML.setName
2024-06-04 18:50:49 +02:00
690a280fa5
avm2: Improve prefix support in ToXMLString
2024-06-04 00:22:42 +02:00
8671bdd8ee
avm2: Implement XML.inScopeNamespaces
2024-06-04 00:22:42 +02:00
0b446d7cc6
avm2: Implement XML.setNamespace
2024-06-04 00:22:42 +02:00
2f7dfd8051
avm2: Implement XML.namespaceDeclarations
2024-06-04 00:22:42 +02:00
f20f57c6f1
avm2: Implement XML.namespace
2024-06-04 00:22:42 +02:00
3f99866ca4
avm2: Implement XML.addNamespace
2024-06-04 00:22:42 +02:00
540cc5fb68
avm1: Stub `bufferLength` and `bufferTime` on `NetStream`
2024-06-03 23:56:22 +02:00
b08750a998
avm1: fix loadvars.send parameters
2024-06-03 23:36:33 +02:00
b9d246b2a5
build(deps): bump the cargo-minor group with 4 updates
...
Bumps the cargo-minor group with 4 updates: [proc-macro2](https://github.com/dtolnay/proc-macro2 ), [toml_edit](https://github.com/toml-rs/toml ), [zip](https://github.com/zip-rs/zip2 ) and [toml](https://github.com/toml-rs/toml ).
Updates `proc-macro2` from 1.0.84 to 1.0.85
- [Release notes](https://github.com/dtolnay/proc-macro2/releases )
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.84...1.0.85 )
Updates `toml_edit` from 0.22.13 to 0.22.14
- [Commits](https://github.com/toml-rs/toml/compare/v0.22.13...v0.22.14 )
Updates `zip` from 2.1.1 to 2.1.2
- [Release notes](https://github.com/zip-rs/zip2/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zip-rs/zip2/compare/v2.1.1...v2.1.2 )
Updates `toml` from 0.8.13 to 0.8.14
- [Commits](https://github.com/toml-rs/toml/compare/toml-v0.8.13...toml-v0.8.14 )
---
updated-dependencies:
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: toml_edit
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: toml
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-06-03 23:21:12 +02:00
224edfe06f
core: Unify WStr::MAX_LEN range checks
2024-06-02 23:00:23 +02:00
6a75def83a
avm2: Fix panic on substr(i, len>usize::MAX)
2024-06-02 23:00:23 +02:00
83cc8cf294
avm2: Implement a few avmplus XML edge cases
2024-06-02 01:52:52 +03:00
1402a59a20
avm2: :Implement FLV Date to Avm2Value conversion
2024-06-02 00:35:36 +02:00
cdbc6d289c
avm2: Implement the abstract equality comparison for QName
2024-06-01 20:52:17 +02:00
febbfe8f42
build(deps): bump the cargo-minor group with 4 updates
...
Bumps the cargo-minor group with 4 updates: [tokio](https://github.com/tokio-rs/tokio ), [regress](https://github.com/ridiculousfish/regress ), [fontdb](https://github.com/RazrFalcon/fontdb ) and [zip](https://github.com/zip-rs/zip2 ).
Updates `tokio` from 1.37.0 to 1.38.0
- [Release notes](https://github.com/tokio-rs/tokio/releases )
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.37.0...tokio-1.38.0 )
Updates `regress` from 0.9.1 to 0.10.0
- [Release notes](https://github.com/ridiculousfish/regress/releases )
- [Commits](https://github.com/ridiculousfish/regress/compare/v0.9.1...v0.10.0 )
Updates `fontdb` from 0.17.0 to 0.18.0
- [Changelog](https://github.com/RazrFalcon/fontdb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RazrFalcon/fontdb/compare/v0.17.0...v0.18.0 )
Updates `zip` from 2.1.0 to 2.1.1
- [Release notes](https://github.com/zip-rs/zip2/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zip-rs/zip2/compare/v2.1.0...v2.1.1 )
---
updated-dependencies:
- dependency-name: tokio
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: regress
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: fontdb
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-06-01 17:46:28 +02:00
618e061564
core: Expand on audio related error messages
2024-06-01 14:08:54 +02:00
f4a517dbd1
text: Invalidate bitmap cache on scroll
...
This patch fixes scrolling text fields when filters are applied.
2024-05-31 22:24:34 +02:00
2fd5dfde9c
avm2: Implement XMLList.normalize
2024-05-31 22:09:17 +02:00
d98e3d9b99
avm2: Parse XML namespace declaration and make ToXMLString output them
...
This does not implement any of the XML API functions that interact with
namespaces.
Fixes #16340
2024-05-30 21:14:06 +02:00
b282d1325a
core: Pass on H.264 packets from FLV streams to the video backend
2024-05-30 20:22:33 +02:00
007a532717
avm2: Implement XMLList.contains
2024-05-30 00:43:45 +03:00
1fe1b8d67d
avm2: Introduce an E4XNamespace type (NFCI)
2024-05-29 22:37:40 +02:00
c32b27c294
core: Fix stop() when executing attachMovie in DoInitAction
...
This fixes a bug where the code in the first frame of a movie clip
could have been executed after the second frame
(so that instructions like stop did not work properly).
That is because when the first frame was executed in preload
(e.g. for a sprite attached using attachMovie), the actions were queued,
the second frame was executed in run_frame, and then the actions from
the first frame were executed.
Ensuring that all actions are executed after preload fixes this issue.
2024-05-28 23:57:13 +02:00
2532d7e927
avm2: Refactor Executable->BoundMethod, introduce freestanding exec()
2024-05-28 23:32:21 +02:00
3bb47db5f9
avm1: Move FunctionObject's base to FunctionObjectData
...
This shrinks AVM1's Object (from 24 to 16 bytes on x64), and
allows future shrinkage of AVM1's Value (e.g. from 24 to 16 bytes
on x64 after putting all strings behind a Gc pointer).
2024-05-28 23:18:11 +02:00
658e800dfc
core: Drop the focus when it's made invisible
...
When an object has focus and is made invisible,
the focus should be dropped.
2024-05-28 23:01:12 +02:00
23c1d32990
core: Pass UpdateContext to set_visible
2024-05-28 23:01:12 +02:00
a6a683ffa1
build(deps): bump the cargo-minor group with 2 updates
...
Bumps the cargo-minor group with 2 updates: [serde](https://github.com/serde-rs/serde ) and [proc-macro2](https://github.com/dtolnay/proc-macro2 ).
Updates `serde` from 1.0.202 to 1.0.203
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.202...v1.0.203 )
Updates `proc-macro2` from 1.0.83 to 1.0.84
- [Release notes](https://github.com/dtolnay/proc-macro2/releases )
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.83...1.0.84 )
---
updated-dependencies:
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-05-28 00:48:13 +02:00
cd24b91a82
avm2: Implement XMLList to XML proxy methods
2024-05-27 21:47:22 +02:00
ab0792904b
avm2: Stub XML.add/set/removeNamespace
2024-05-27 21:47:22 +02:00
381b0897c9
avm2: Implement ExternalInterface.objectID
2024-05-26 23:00:33 +02:00
1bf9756b4e
text: Allow selecting text by dragging
...
This patch allows selecting text by pressing and dragging the mouse.
2024-05-26 12:38:16 +02:00
bafc5d250e
tests: Add a depdendent string test, with test-only AS3
2024-05-26 12:14:30 +02:00
d6dbc5e767
core: Support dependent strings for concatenation
2024-05-26 12:14:30 +02:00
f712c9212c
build(deps): bump syn from 2.0.65 to 2.0.66 in the cargo-minor group
...
Bumps the cargo-minor group with 1 update: [syn](https://github.com/dtolnay/syn ).
Updates `syn` from 2.0.65 to 2.0.66
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.65...2.0.66 )
---
updated-dependencies:
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-05-25 17:35:23 +02:00
f8e97808e4
core: Store MovieClip avm2_class in MovieClipStatic
...
This is preparation for allowing a class to be linked
to the root movie clip and instantiated.
2024-05-25 10:14:44 -04:00
0edb7d6890
core: KeyPress events have precedence over tabbing
...
When there's a button that handles KeyPress "Tab" event (code 18),
the tabbing should not be performed.
2024-05-25 01:12:43 +02:00
277390aab4
core: Render EditText's selection when filters are present
...
This patch ensures that the selection in EditText is rendered even when
filters are present (so that cache as bitmap is enabled).
This is done by invalidating the cached bitmap on selection change.
2024-05-24 23:52:03 +02:00
8ac7a58d4e
debug_ui: Improve EditText tab
...
This patch adds multiple properties and controls to EditText tab.
This includes for instance:
* border, border color,
* background, background color,
* editable, selectable, word wrap properties,
* autosize, max chars, restrict, etc.
2024-05-24 09:07:21 -04:00
6c67e7485e
core: Invalidate EditText's bitmap when border is disabled
...
This patch makes sure that the bitmap is invalidated not only when
a border or background was enabled, but also when both were disabled
and the drawing has only been cleared.
2024-05-24 09:07:21 -04:00
671be1a810
avm2: Fix a few XML prototype method signatures
2024-05-21 23:51:35 +02:00
3949110f6b
avm2: request_from_url_request should fail when the url property is null
2024-05-21 20:45:20 +02:00
f54e3fdbd0
avm2: Introduce the make_error_2007 helper
2024-05-21 20:45:20 +02:00
a5c3474bbc
avm2: Implement Namespace enumeration
2024-05-21 20:26:35 +02:00
b9947a2d1c
avm2: Add more Namespace tests and fixed some other cases
2024-05-21 19:57:39 +02:00
3692cbbb2e
avm2: Implement Namespace constructor and prefix
2024-05-21 19:57:39 +02:00
2dec49941a
chore: Refer to a specific git hash of jpegxr instead of a branch
2024-05-21 18:38:29 +02:00
c0b0b8257f
build(deps): bump the cargo-minor group with 6 updates
...
----
updated-dependencies:
- dependency-name: anyhow
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: crossbeam-channel
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-20 20:56:02 +00:00
f301b23f6e
core: Treat NaN rotation as 0.0 when setting scaleX/scaleY
...
The `rotation` value is still reported to ActionScript as `NaN`,
but we treat it as 0.0 when computing the new matrix in the
scaleX/scaleY setters.
2024-05-19 09:52:07 -07:00
78e9426ba9
avm2: Add some comments for clarification
2024-05-18 17:01:49 -07:00
c93873a7a2
avm2: Add a note on the `FindProp(Strict)` to `GetScriptGlobals` optimization
2024-05-18 17:01:49 -07:00
a88d9dc07b
avm2: Simple scoping is not required to optimize GetGlobalScope and GetGlobalSlot
2024-05-18 17:01:49 -07:00
267e3693ca
Appease clippy
2024-05-18 17:01:49 -07:00
3fb549f1b5
avm2: Handle lazy multiname in findprop optimization
2024-05-18 17:01:49 -07:00
eb27151af7
avm2: Don't call global init in optimizer
2024-05-18 17:01:49 -07:00
12174b5219
avm2: Propagate types from getslot, getglobalscope, and getglobalslot in optimizer
2024-05-18 17:01:49 -07:00
92de618261
avm2: Fix some very minor bugs with findprop optimization
2024-05-18 17:01:49 -07:00
796dda1ae0
avm2: Remove `fork_vtable` hack
2024-05-18 17:01:49 -07:00
767b7b4e44
avm2: Optimize findproperty and findpropstrict to getouterscope, getscopeobject, and getscriptglobals when possible
2024-05-18 17:01:49 -07:00
f50b68abfd
avm2: Split `GetLex` into `FindPropStrict` and `GetProperty`
2024-05-18 17:01:49 -07:00
f573f7b141
avm1: Make clip have correct properties when the target of loadClip
2024-05-17 23:07:44 +02:00
5fbf39fd7a
build(deps): bump the cargo-minor group across 1 directory with 7 updates
...
Bumps the cargo-minor group with 7 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [async-channel](https://github.com/smol-rs/async-channel ) | `2.3.0` | `2.3.1` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.201` | `1.0.202` |
| [either](https://github.com/rayon-rs/either ) | `1.11.0` | `1.12.0` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.63` | `2.0.64` |
| [toml_edit](https://github.com/toml-rs/toml ) | `0.22.12` | `0.22.13` |
| [insta](https://github.com/mitsuhiko/insta ) | `1.38.0` | `1.39.0` |
| [toml](https://github.com/toml-rs/toml ) | `0.8.12` | `0.8.13` |
Updates `async-channel` from 2.3.0 to 2.3.1
- [Release notes](https://github.com/smol-rs/async-channel/releases )
- [Changelog](https://github.com/smol-rs/async-channel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/smol-rs/async-channel/compare/v2.3.0...v2.3.1 )
Updates `serde` from 1.0.201 to 1.0.202
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.201...v1.0.202 )
Updates `either` from 1.11.0 to 1.12.0
- [Commits](https://github.com/rayon-rs/either/compare/1.11.0...1.12.0 )
Updates `syn` from 2.0.63 to 2.0.64
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.63...2.0.64 )
Updates `toml_edit` from 0.22.12 to 0.22.13
- [Commits](https://github.com/toml-rs/toml/compare/v0.22.12...v0.22.13 )
Updates `insta` from 1.38.0 to 1.39.0
- [Release notes](https://github.com/mitsuhiko/insta/releases )
- [Changelog](https://github.com/mitsuhiko/insta/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mitsuhiko/insta/compare/1.38.0...1.39.0 )
Updates `toml` from 0.8.12 to 0.8.13
- [Commits](https://github.com/toml-rs/toml/compare/toml-v0.8.12...toml-v0.8.13 )
---
updated-dependencies:
- dependency-name: async-channel
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: either
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: toml_edit
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: insta
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: toml
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-05-17 01:41:44 +02:00
b25fe69bac
avm1: Implement StyleSheet.load
2024-05-17 00:37:39 +02:00
c1e197189d
avm1: Implement most of StyleSheet
2024-05-17 00:37:39 +02:00
331d1789da
render,core,desktop: Port to `wgpu` `v0.20.0`, switch to `egui` `master`
2024-05-17 01:19:01 +03:00
b8c1263f9e
avm1: Expose NativeObjects through SuperObject - fixes g2conline
2024-05-17 00:02:45 +02:00
dfd9a26a7b
avm1: Implement NetConnection, more or less
2024-05-17 00:02:45 +02:00
aeabe3cbb5
core: Implement proper automatic tab ordering
...
This patch implements proper automatic tab ordering that
behaves exactly the same as in FP.
The automatic order depends only on the position of
the top-left highlight bound corner, referred to as `(x,y)`.
It does not depend on object's size or other corners.
The value of `6y+x` is used to order objects by it.
This means that the next object to be tabbed is the next one
that touches the line `y=-(x-p)/6` (with the smallest `p`).
When two objects have the same value of `6y+x`
(i.e. when the line touches two objects at the same time),
only one of them is included.
This behavior is similar to the naive approach of
"left-to-right, top-to-bottom", but (besides being sometimes
seen as random jumps) takes into account the fact that
the next object to the right may be positioned slightly higher.
This is especially true for objects placed by hand or objects with
different heights (as FP uses the top left corner instead of the center).
This behavior has been discovered experimentally by placing
tabbable objects randomly and bisecting one of their
coordinates to find a difference in behavior.
2024-05-16 21:40:56 +02:00
be8cbd64d6
core/render/web: Make FromStr exclusively for snake_case
2024-05-16 01:14:42 +03:00
519de0e230
avm1: Implement __resolve
2024-05-15 22:45:56 +02:00
932f2d410b
debug_ui: Render bitmap in new 'Bitmap' display object tab
...
This lets us view a bitmap directly from the debug ui.
We cache an egui texture handle on the `BitmapData` itself,
and invalidate it whenever the BitmapData gets changed.
2024-05-15 15:19:52 -04:00
4d2b2893ae
avm2: Prevent loader mouse pick from targeting direct child
...
Loaders have a similar behavior to the main stage - if a mouse pick
would target their direct child (the root movieclip in the stage case,
and the loaded MovieClip in the Loader case), the Stage/Loader is
targeted instead.
2024-05-15 13:41:17 -04:00
60000d6930
avm2: Skip mouse pick for all mask children
...
We were previosuly only checking 'clip_depth', but we should
also check 'maskee()'
2024-05-15 12:30:51 -04:00
b5948a883a
avm2: Simplify string comparison in stylesheet a bit
2024-05-14 21:03:37 +02:00
4691d0c798
avm2: Call transform from StyleSheet.setStyle()
2024-05-14 21:03:37 +02:00
7309e457d5
avm2: Transform css properties from with-dashes to snakeCase
2024-05-14 21:03:37 +02:00
24b01b8f89
avm2: Implement StyleSheet.transform()
2024-05-14 21:03:37 +02:00
7e1bc84bdf
avm2: Implement most of StyleSheet
2024-05-14 21:03:37 +02:00
8eb8673122
core: Update a comment related to custom tab ordering
...
Turns out the existing implementation was right.
2024-05-14 18:33:46 +02:00
5dcb87c727
debug_ui: Add stage focus rect
2024-05-13 20:48:48 +02:00
f713c90cca
core: Add possibility to set tab_enabled in AVM1
...
This makes it possible to set it from the debug UI.
2024-05-13 20:48:48 +02:00
0c3ab81671
debug_ui: Fix a positioning issue in Stage tab
2024-05-13 20:48:48 +02:00
a5b7933c26
debug_ui: Add a tab for interactive objects
2024-05-13 20:48:48 +02:00
4253525f8b
core: Add InteractiveObject.tab_enabled_default
...
This patch removes two methods:
* `tab_enabled_avm1`, and
* `tab_enabled_avm2_default`,
and replaces them with `tab_enabled_default`.
This refactor makes the code more readable and simple.
2024-05-13 20:48:48 +02:00
819abe8420
build(deps): bump the cargo-minor group with 14 updates
...
Bumps the cargo-minor group with 14 updates:
| Package | From | To |
| --- | --- | --- |
| [async-channel](https://github.com/smol-rs/async-channel ) | `2.2.1` | `2.3.0` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.200` | `1.0.201` |
| [thiserror](https://github.com/dtolnay/thiserror ) | `1.0.59` | `1.0.60` |
| [linkme](https://github.com/dtolnay/linkme ) | `0.3.25` | `0.3.26` |
| [bitstream-io](https://github.com/tuffy/bitstream-io ) | `2.2.0` | `2.3.0` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.116` | `1.0.117` |
| [ttf-parser](https://github.com/RazrFalcon/ttf-parser ) | `0.20.0` | `0.21.1` |
| [num-bigint](https://github.com/rust-num/num-bigint ) | `0.4.4` | `0.4.5` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.60` | `2.0.63` |
| [proc-macro2](https://github.com/dtolnay/proc-macro2 ) | `1.0.81` | `1.0.82` |
| [fontdb](https://github.com/RazrFalcon/fontdb ) | `0.16.2` | `0.17.0` |
| [unic-langid](https://github.com/zbraniecki/unic-locale ) | `0.9.4` | `0.9.5` |
| [zip](https://github.com/zip-rs/zip2 ) | `1.2.0` | `1.2.3` |
| [libtest-mimic](https://github.com/LukasKalbertodt/libtest-mimic ) | `0.7.2` | `0.7.3` |
Updates `async-channel` from 2.2.1 to 2.3.0
- [Release notes](https://github.com/smol-rs/async-channel/releases )
- [Changelog](https://github.com/smol-rs/async-channel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/smol-rs/async-channel/compare/v2.2.1...v2.3.0 )
Updates `serde` from 1.0.200 to 1.0.201
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.200...v1.0.201 )
Updates `thiserror` from 1.0.59 to 1.0.60
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.59...1.0.60 )
Updates `linkme` from 0.3.25 to 0.3.26
- [Release notes](https://github.com/dtolnay/linkme/releases )
- [Commits](https://github.com/dtolnay/linkme/compare/0.3.25...0.3.26 )
Updates `bitstream-io` from 2.2.0 to 2.3.0
- [Commits](https://github.com/tuffy/bitstream-io/compare/v2.2.0...v2.3.0 )
Updates `serde_json` from 1.0.116 to 1.0.117
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.116...v1.0.117 )
Updates `ttf-parser` from 0.20.0 to 0.21.1
- [Changelog](https://github.com/RazrFalcon/ttf-parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RazrFalcon/ttf-parser/compare/v0.20.0...v0.21.1 )
Updates `num-bigint` from 0.4.4 to 0.4.5
- [Changelog](https://github.com/rust-num/num-bigint/blob/master/RELEASES.md )
- [Commits](https://github.com/rust-num/num-bigint/compare/num-bigint-0.4.4...num-bigint-0.4.5 )
Updates `syn` from 2.0.60 to 2.0.63
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.60...2.0.63 )
Updates `proc-macro2` from 1.0.81 to 1.0.82
- [Release notes](https://github.com/dtolnay/proc-macro2/releases )
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.81...1.0.82 )
Updates `fontdb` from 0.16.2 to 0.17.0
- [Changelog](https://github.com/RazrFalcon/fontdb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RazrFalcon/fontdb/compare/v0.16.2...v0.17.0 )
Updates `unic-langid` from 0.9.4 to 0.9.5
- [Release notes](https://github.com/zbraniecki/unic-locale/releases )
- [Commits](https://github.com/zbraniecki/unic-locale/commits )
Updates `zip` from 1.2.0 to 1.2.3
- [Release notes](https://github.com/zip-rs/zip2/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zip-rs/zip2/compare/v1.2.0...v1.2.3 )
Updates `libtest-mimic` from 0.7.2 to 0.7.3
- [Release notes](https://github.com/LukasKalbertodt/libtest-mimic/releases )
- [Changelog](https://github.com/LukasKalbertodt/libtest-mimic/blob/master/CHANGELOG.md )
- [Commits](https://github.com/LukasKalbertodt/libtest-mimic/compare/v0.7.2...v0.7.3 )
---
updated-dependencies:
- dependency-name: async-channel
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: linkme
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: bitstream-io
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: ttf-parser
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: num-bigint
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: fontdb
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: unic-langid
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: libtest-mimic
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-05-13 15:49:29 +02:00
272c07ea3b
avm2: Implement `describeType(null)` stub ( #16235 )
2024-05-10 22:06:56 +00:00
b1b7ccfbd2
avm1: Highlight buttons using their hit bounds
...
Buttons are always highlighted using their hit bounds.
I guess it does have some sense to it, because their bounds
usually change on hover (children are swapped out),
which would cause the automatic tab order to change during tabbing.
That could potentially create a loop in the tab ordering
(soft locking the tab).
2024-05-10 23:52:01 +02:00
1e5439ab68
core: Add InteractiveObject.highlight_bounds() method
...
This method returns the world bounds of
the focus highlight for the interactive object.
2024-05-10 23:52:01 +02:00
da9c9527e5
core: Allow pressing buttons with keyboard
...
This patch allows the keyboard to be used (Enter/Space) to press buttons.
2024-05-10 22:42:03 +02:00
18d9035685
core: Fire button event handlers only when highlight is active
...
It seems that button event handlers not only require focus to be fired,
but also an active highlight.
2024-05-10 22:42:03 +02:00
97a454cc36
core: Refactor a common condition to should_fire_button_event_handlers
...
This condition is identical for buttons and movie clips.
2024-05-10 22:42:03 +02:00
bfb7e57277
debug_ui: Improve highlight display, add re-focus button
...
Since highlight has 3 states now, it's better represented by
describing the state instead of having a checkbox.
A re-focus button has been added to compensate for the fact
that the highlight cannot be automatically enabled anymore.
2024-05-10 22:42:03 +02:00
df714d35bd
core: Differentiate between active and visible highlight
...
Some button events (e.g. KeyUp/KeyDown) seem to require a state when
the highlight is not visible, but is active (i.e. a focus is selected).
That is why this patch introduces a third possible state of
the highlight: ActiveHidden.
2024-05-10 22:42:03 +02:00
11c1120364
core: Invalidate cached bitmap on every newly decoded video frame
...
Not just when seeking manually. And request rendering to be sure.
2024-05-10 09:56:47 +02:00
8eaede1c2c
avm2: Try to speed up domain memory ops
2024-05-09 16:41:12 -07:00
8ab19054aa
avm2: Create bad branch errors lazily in verifier
2024-05-09 16:41:12 -07:00
4df7722aab
avm2: Add fast path for setting array property
2024-05-09 16:41:12 -07:00
ed037214b1
core: Always fire KeyPress after KeyDown for buttons
...
Button events are actually handled twofold:
1. KeyPress for printable characters is handled on TextInput,
2. KeyPress for special characters (e.g. enter, arrows)
is handled on KeyDown.
Before this patch, KeyPress was fired too early, so that for
special characters (2) it fired BEFORE KeyDown.
This was not a problem for printable characters, as they
fired on TextInput, which always fired separately after KeyDown.
This patch ensures that KeyPress is fired always in the proper order.
2024-05-09 21:13:13 +02:00
5541daa105
debug_ui: Add interactive tab order list
2024-05-09 20:57:53 +02:00
baa87ff016
core: Add FocusTracker::tab_order method
...
This method returns the current tab order as a list of objects.
2024-05-09 20:57:53 +02:00
ccf6b3edb5
debug_ui: Add possibility to clear current focus
2024-05-09 20:57:53 +02:00
ab62b740a7
debug_ui: Use open_display_object_button for focus
2024-05-09 20:57:53 +02:00
4e39598da4
debug_ui: Exclude hidden objects properly when searching
...
The option "Include Hidden" was not working properly,
as it did not exclude all hidden objects when disabled.
An object is hidden also when its ancestor is not visible.
2024-05-09 08:12:59 -07:00
ece156e478
core: Use draw_rect_outline for focus highlight
...
This ensures that highlight does not become outdated
(e.g. when the highlighted content moves).
Additionally, it makes the highlight have 3px independently of zoom.
2024-05-09 00:40:25 +02:00
07bfa0c3e2
core: Use draw_rect_outline for debug rects
...
This improves debug rect rendering so that debug rects
do not have missing corners as before.
2024-05-09 00:40:25 +02:00
eabf76dae8
core: Add RenderContext::draw_rect_outline
...
This method may be used to efficiently draw a simple rectangle outline
for debug rects and focus rects.
2024-05-09 00:40:25 +02:00
bc4ed4c5a1
core: Improve performance of round_to_even
...
This patch improves performance of ecma_conversions::round_to_even():
1. by using f64::round_ties_even(), which has been stable
since 1.77.0, instead of a custom algorithm; and
2. by removing an unnecessary comparison to i32::MIN,
as casting a float to an integer automatically saturates
values smaller than the minimum integer value to the minimum
value of the integer type.
2024-05-08 22:16:40 +02:00
8eaf844cdc
core: Add tests for round_to_even
2024-05-08 22:16:40 +02:00
b551d14a59
avm2: Ensure the focus is dropped when it's removed
...
The logic of dropping the focus when it's removed
applies not only to TextFields but for every InteractiveObject.
This patch ensures that any focus is dropped when its parent is removed.
2024-05-07 22:56:25 +02:00
428688e7e7
core: Add DisplayObject.on_parent_removed method
...
This method prevents code duplication performed when overwriting
set_parent to inject some behavior when the parent is removed.
2024-05-07 22:56:25 +02:00
8d50d1fead
core: Move has_focus to InteractiveObject
...
All the interactive objects had the has_focus flag in their concrete
implementations (even AVM2 button, which did not use it at all).
This patch moves it to InteractiveObject (as a bit flag), making it
easier to manage and use through the has_focus, set_has_focus methods.
Additionally, the operation of setting the current focus to None
when an object was having it was popular enough that it warranted its
own method of drop_focus.
2024-05-07 22:56:25 +02:00
120bfa2b30
avm2: Send ADDED_TO_STAGE in SimpleButton at correct time
2024-05-07 22:42:52 +02:00
8e6e71b2f7
web: Download the file on FileReference.save
...
This patch adds support for saving files on web using FileReference.
When writing data, a download is triggered with the default file name.
Currently, there's no dialog that lets the user select save destination.
This patch also ensures that all implementations of FileDialogResult
behave the same way: desktop, web, and tests.
The methods `write` and `refresh` have been merged into one:
`write_and_refresh`, which allows the tests and web implementations
behave the same way as desktop.
2024-05-07 22:26:30 +02:00
64df0368fd
avm2: Fix TextField.selectedText
2024-05-06 22:17:41 +02:00
901a88db29
avm2: Implement selectedText in class flash.text.TextField
2024-05-06 22:17:41 +02:00
0c38cc9e28
avm2: share binding skip optimization with `call_method`
2024-05-06 22:02:45 +02:00
0910df8307
avm2: Implement XML.contains ( #16206 )
...
* avm2: XML.contains() implemented
* tests: XMLList known_failure removed
* avm2: XML manual checks removed
* avm2: XMLList.contains() behavior fixed
* avm2: XML contains method moved to xml.rs
* avm2: Empty line removed in xml.rs
* avm2: XML contains args name renamed to value
2024-05-06 17:40:03 +00:00
42c26f61d1
core: Call focus handlers on every object
...
Before this patch, focus handlers were called from on_focus_changed,
only for selected objects. It seems that they should be called for
every object by default.
2024-05-04 17:05:24 -07:00
f5a0751557
avm2: Do not highlight Stage on focus
...
Stage is never highlightable, even if there's a focus on it.
2024-05-04 17:05:24 -07:00
aa006f0e8f
chore: Update translations from Crowdin
2024-05-02 18:07:40 +02:00
8ee514e62f
avm2: Handle setting tabIndex to -1
...
Despite throwing an error that `tabIndex` cannot be negative,
the value of -1 is allowed, and it means that `tabIndex` is unset.
2024-04-30 14:23:45 +02:00
f40cb6435f
code: Unset tabIndex upon assigning -1
...
The value of -1 for tabIndex always means that it's unset,
even in AVM1 where tabIndex may have a value of `undefined`.
2024-04-30 14:23:45 +02:00
054d0aab29
chore: Update translations from Crowdin
2024-04-30 01:14:39 +02:00
ec2aaa0549
avm2: Implement InteractiveObject.focusRect
2024-04-29 23:41:40 +02:00
6191984dd6
build(deps): bump the cargo-minor group with 4 updates
...
Bumps the cargo-minor group with 4 updates: [flate2](https://github.com/rust-lang/flate2-rs ), [hashbrown](https://github.com/rust-lang/hashbrown ), [gilrs](https://gitlab.com/gilrs-project/gilrs ) and [zip](https://github.com/Pr0methean/zip ).
Updates `flate2` from 1.0.29 to 1.0.30
- [Release notes](https://github.com/rust-lang/flate2-rs/releases )
- [Commits](https://github.com/rust-lang/flate2-rs/compare/1.0.29...1.0.30 )
Updates `hashbrown` from 0.14.3 to 0.14.5
- [Changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/hashbrown/compare/v0.14.3...v0.14.5 )
Updates `gilrs` from 0.10.6 to 0.10.7
- [Commits](https://gitlab.com/gilrs-project/gilrs/compare/v0.10.6...v0.10.7 )
Updates `zip` from 1.1.1 to 1.1.2
- [Release notes](https://github.com/Pr0methean/zip/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Pr0methean/zip/compare/1.1.1...v1.1.2 )
---
updated-dependencies:
- dependency-name: flate2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: hashbrown
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: gilrs
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 23:18:44 +02:00
0479259fb9
avm2: Implement DisplayObjectContainer.tabChildren
2024-04-29 21:54:06 +02:00
e3bc63f2bf
core: Add possibility to set tab_children for containers
2024-04-29 21:54:06 +02:00
39b6c9d096
avm2: Implement InteractiveObject.tabEnabled
2024-04-29 21:54:06 +02:00
1ecdaea392
avm2: Implement InteractiveObject.tabIndex
2024-04-29 21:54:06 +02:00
14f7665912
core: Allow setting tabEnabled for AVM2
...
The field tab_enabled in AVM1 is effectively read-only as
tabEnabled is not a built-in property of objects.
That is not the case in AVM2, where tab_enabled is native.
This patch covers both of these cases by introducing methods:
* tab_enabled,
* set_tab_enabled,
* tab_enabled_avm1,
* tab_enabled_avm2_default.
2024-04-29 21:54:06 +02:00
036b898122
avm2: Call focus handler in AVM2 buttons
...
The focus handler should also be called for AVM2 buttons when
the focus is being changed.
2024-04-29 21:54:06 +02:00
02091e590d
avm1: Move tab_index to InteractiveObject and make it i32
...
The i32/u32 discrepancy is only a data presentation issue,
as the value is treated as i32 in every case.
2024-04-29 21:54:06 +02:00
e7eaf2a640
avm2: Override inapplicable properties in TextLine
...
Some inherited properties of `TextLine` are inapplicable.
They always return the default value and throw an error when set.
2024-04-29 21:18:08 +02:00
b0443b3b5f
avm2: Simplify uses of `GcCell<'gc, Class<'gc>>`
2024-04-27 08:29:10 -07:00
868ab45c98
avm2: Add Stage.softKeyboardRect
2024-04-24 20:33:13 +02:00
953a741943
core: Update focus highlight reset logic for SWF9+
...
SWF versions 9 onwards reset the highlight only on
left mouse button down, whereas older versions also
reset it on other mouse events.
2024-04-24 00:49:37 +02:00
83d5d18a20
avm2: Add missing overrides to Stage
...
Stage overrides some properties from its super classes.
Some of them are currently identical in Ruffle,
but in FP they are used for e.g. security checks.
2024-04-23 23:13:02 +02:00
f01cb99d1a
avm2: Remove unnecessary imports in AS
2024-04-23 23:13:02 +02:00
ccd2922973
avm2: Stub DisplayObjectContainer.textSnapshot
2024-04-23 23:13:02 +02:00
19cc8e5873
avm2: Add a stub for flash.text.TextSnapshot
2024-04-23 23:13:02 +02:00
09e932163b
xml: Add TODO comment in deepCopy()
2024-04-22 22:08:40 +02:00
43f27b80ce
avm2: Also conditionally set IS_QNAME in 'new QName()'
2024-04-22 22:08:40 +02:00
464ccb6eb6
avm2: Update comment for QName struct
2024-04-22 22:08:40 +02:00
fd281cc715
avm2: Add IS_QNAME flag to Multiname, improve XML name matching
2024-04-22 22:08:40 +02:00
c6bfaf8fae
build(deps): bump the cargo-minor group with 4 updates
...
Bumps the cargo-minor group with 4 updates: [thiserror](https://github.com/dtolnay/thiserror ), [fluent-templates](https://github.com/XAMPPRocky/fluent-templates ), [toml_edit](https://github.com/toml-rs/toml ) and [reqwest](https://github.com/seanmonstar/reqwest ).
Updates `thiserror` from 1.0.58 to 1.0.59
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.58...1.0.59 )
Updates `fluent-templates` from 0.9.2 to 0.9.4
- [Release notes](https://github.com/XAMPPRocky/fluent-templates/releases )
- [Changelog](https://github.com/XAMPPRocky/fluent-templates/blob/master/CHANGELOG.md )
- [Commits](https://github.com/XAMPPRocky/fluent-templates/compare/fluent-templates-v0.9.2...fluent-templates-v0.9.4 )
Updates `toml_edit` from 0.22.9 to 0.22.12
- [Commits](https://github.com/toml-rs/toml/compare/v0.22.9...v0.22.12 )
Updates `reqwest` from 0.12.3 to 0.12.4
- [Release notes](https://github.com/seanmonstar/reqwest/releases )
- [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/seanmonstar/reqwest/compare/v0.12.3...v0.12.4 )
---
updated-dependencies:
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: fluent-templates
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: toml_edit
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: reqwest
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-22 20:33:27 +02:00
15c076fe0c
avm2: Remove "namespace not matching" message
...
This was getting spammed after #16069
2024-04-21 16:12:54 -07:00
b9e9a3e1f2
core: Dispatch rollOut/rollOver events on focus change and Tab
...
When focus changes, rollOut/rollOver events should be dispatched.
This includes onRollOut/onRollOver handlers, but also button actions.
2024-04-22 00:53:20 +02:00
e20341f0a3
core: Skip updating mouse hover when not necessary
...
Since objects may be hovered using Tab, mouse hover update cannot happen
every time, because it would always reset the hover set by Tab.
This is why mouse hover is skipped when the following are true:
1. the mouse has not moved,
2. no mouse button has been pressed,
3. there was a hover,
4. the hovered object did not disappear.
2024-04-22 00:53:20 +02:00
9987519608
core: Make FocusTracker operate on InteractiveObjects
...
Originally, FocusTracker operated on DisplayObjects. However, in both
AVM1 and AVM2, all objects that are focusable are InteractiveObjects.
Switching FocusTracker to operate on InteractiveObjects simplifies code
in the long run.
2024-04-22 00:53:20 +02:00
f94a31c5c2
core: Add FocusTracker.get_as_edit_text method
...
This is a utility method which simplifies getting the current focus
as an EditText object, which is being done frequently throughout Ruffle.
2024-04-22 00:53:20 +02:00
31c9be3a35
core: Ensure all changes made to UpdateContext are applied
...
UpdateContext.mouse_over_object and UpdateContext.mouse_down_object
were treated differently from other properties. Changes made to them
were required to be applied manually after using the context.
However, when reborrowing the context, all changes made to these
properties were dropped, as they were not applied after reborrow.
Applying them after reborrow would be difficult (RAII, concurrency
problems), that's why they were replaced with mutable references.
MouseData struct was introduced to make the code more readable and
adhere to the convention of UpdateContext to contain mutable references
to higher level objects.
2024-04-22 00:53:20 +02:00
e28712f111
avm1: Use Avm1::run_stack_frame_for_method for focus handlers
...
Using Avm1::run_stack_frame_for_method for calling focus handlers
simplifies code and prevents duplication.
2024-04-22 00:53:20 +02:00
47758e1fb3
core: Make objects focusable by default
...
Since is_focusable has been moved to InteractiveObject,
it may now return true by default, because non-interactive objects
do not implement this method anymore.
2024-04-22 00:53:20 +02:00
5173fa4118
core: Move focus-related methods to InteractiveObject
...
Only interactive objects may be focusable, so keeping these methods
in all display objects makes matters more difficult, as they also
has to be implemented for non-interactive objects.
Moving these to InteractiveObject simplifies code in the long run.
2024-04-22 00:53:20 +02:00
ca4da9e5ee
avm2: Fix regression from classes not being registered in order from the constant pool
2024-04-21 14:27:16 -07:00
8a4946fa03
avm2: Store Class instead of QName as superclass of Class
2024-04-20 15:23:44 -07:00
3f5582ed94
avm1: Correct `getBounds` properties order
...
This affects the order of the properties when enumerating the
returned object (via `Enumerate2` etc.)
2024-04-20 21:58:32 +02:00
7e349d9190
avm2: Add support for sparse arrays
2024-04-20 21:41:33 +02:00
3ca7cc821e
nit: Silence nightly `dead_code` lint
2024-04-20 17:39:54 +02:00
b8ec3a8089
nit: Silence nightly `clippy::legacy_numeric_constants` lint
2024-04-20 17:39:54 +02:00
955d03885e
avm2: Remove outdated TODO comments
2024-04-19 15:03:53 -07:00
cdf587c5a5
avm2: Fix two bugs that caused wrong query parameters with navigateToURL
2024-04-19 18:56:25 +02:00
5c1fcb9f26
build(deps): bump the cargo-minor group with 4 updates
...
Bumps the cargo-minor group with 4 updates: [serde](https://github.com/serde-rs/serde ), [serde_json](https://github.com/serde-rs/json ), [syn](https://github.com/dtolnay/syn ) and [proc-macro2](https://github.com/dtolnay/proc-macro2 ).
Updates `serde` from 1.0.197 to 1.0.198
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.197...v1.0.198 )
Updates `serde_json` from 1.0.115 to 1.0.116
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.115...v1.0.116 )
Updates `syn` from 2.0.59 to 2.0.60
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.59...2.0.60 )
Updates `proc-macro2` from 1.0.80 to 1.0.81
- [Release notes](https://github.com/dtolnay/proc-macro2/releases )
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.80...1.0.81 )
---
updated-dependencies:
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-18 17:30:02 +02:00
a69b80b4bb
avm2: Allow splice() on a Vector with fixed=true
2024-04-18 00:56:22 +02:00
899fe54477
debug_ui: Show mouseEnabled/mouseChildren/doubleClickEnabled
...
This helps with debugging mouse-pick bugs
2024-04-17 14:36:34 -04:00
899c0bb157
chore: fix some typos in comments
...
Signed-off-by: StevenMia <flite@foxmail.com>
2024-04-16 09:31:00 +02:00
d3cc9d5fa5
build(deps): bump the cargo-minor group with 11 updates
...
Bumps the cargo-minor group with 11 updates:
| Package | From | To |
| --- | --- | --- |
| [anyhow](https://github.com/dtolnay/anyhow ) | `1.0.81` | `1.0.82` |
| [async-channel](https://github.com/smol-rs/async-channel ) | `2.2.0` | `2.2.1` |
| [chrono](https://github.com/chronotope/chrono ) | `0.4.37` | `0.4.38` |
| [encoding_rs](https://github.com/hsivonen/encoding_rs ) | `0.8.33` | `0.8.34` |
| [fluent-templates](https://github.com/XAMPPRocky/fluent-templates ) | `0.9.1` | `0.9.2` |
| [either](https://github.com/rayon-rs/either ) | `1.10.0` | `1.11.0` |
| [quote](https://github.com/dtolnay/quote ) | `1.0.35` | `1.0.36` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.58` | `2.0.59` |
| [proc-macro2](https://github.com/dtolnay/proc-macro2 ) | `1.0.79` | `1.0.80` |
| [webbrowser](https://github.com/amodm/webbrowser-rs ) | `0.8.14` | `0.8.15` |
| [libtest-mimic](https://github.com/LukasKalbertodt/libtest-mimic ) | `0.7.0` | `0.7.2` |
Updates `anyhow` from 1.0.81 to 1.0.82
- [Release notes](https://github.com/dtolnay/anyhow/releases )
- [Commits](https://github.com/dtolnay/anyhow/compare/1.0.81...1.0.82 )
Updates `async-channel` from 2.2.0 to 2.2.1
- [Release notes](https://github.com/smol-rs/async-channel/releases )
- [Changelog](https://github.com/smol-rs/async-channel/blob/master/CHANGELOG.md )
- [Commits](https://github.com/smol-rs/async-channel/compare/v2.2.0...v2.2.1 )
Updates `chrono` from 0.4.37 to 0.4.38
- [Release notes](https://github.com/chronotope/chrono/releases )
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md )
- [Commits](https://github.com/chronotope/chrono/compare/v0.4.37...v0.4.38 )
Updates `encoding_rs` from 0.8.33 to 0.8.34
- [Commits](https://github.com/hsivonen/encoding_rs/compare/v0.8.33...v0.8.34 )
Updates `fluent-templates` from 0.9.1 to 0.9.2
- [Release notes](https://github.com/XAMPPRocky/fluent-templates/releases )
- [Changelog](https://github.com/XAMPPRocky/fluent-templates/blob/master/CHANGELOG.md )
- [Commits](https://github.com/XAMPPRocky/fluent-templates/compare/fluent-templates-v0.9.1...fluent-templates-v0.9.2 )
Updates `either` from 1.10.0 to 1.11.0
- [Commits](https://github.com/rayon-rs/either/compare/1.10.0...1.11.0 )
Updates `quote` from 1.0.35 to 1.0.36
- [Release notes](https://github.com/dtolnay/quote/releases )
- [Commits](https://github.com/dtolnay/quote/compare/1.0.35...1.0.36 )
Updates `syn` from 2.0.58 to 2.0.59
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.58...2.0.59 )
Updates `proc-macro2` from 1.0.79 to 1.0.80
- [Release notes](https://github.com/dtolnay/proc-macro2/releases )
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.79...1.0.80 )
Updates `webbrowser` from 0.8.14 to 0.8.15
- [Release notes](https://github.com/amodm/webbrowser-rs/releases )
- [Changelog](https://github.com/amodm/webbrowser-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/amodm/webbrowser-rs/compare/v0.8.14...v0.8.15 )
Updates `libtest-mimic` from 0.7.0 to 0.7.2
- [Release notes](https://github.com/LukasKalbertodt/libtest-mimic/releases )
- [Changelog](https://github.com/LukasKalbertodt/libtest-mimic/blob/master/CHANGELOG.md )
- [Commits](https://github.com/LukasKalbertodt/libtest-mimic/commits )
---
updated-dependencies:
- dependency-name: anyhow
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: async-channel
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: chrono
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: encoding_rs
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: fluent-templates
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: either
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: quote
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: webbrowser
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: libtest-mimic
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-15 23:34:51 +02:00
1f4eebfd8d
avm2: Add SetSlotNoCoerce and ReturnValueNoCoerce ops for SetSlot and ReturnValue without coercion when type is guaranteed to be not coerced
2024-04-14 22:10:37 -07:00
daaf274245
avm2: Fill in all ops in optimizer
2024-04-14 22:10:37 -07:00
efe878211a
avm2: Pre-pool multinames for several ops
...
`CallPropLex`, `GetSuper`, `SetSuper`, `CallSuper`, `CallSuperVoid`, `GetDescendants`
2024-04-14 22:10:37 -07:00
a7021f4fee
avm2: Use already stored param types in optimizer
2024-04-14 22:10:37 -07:00
e05f405888
avm2: Remove unneeded zero code length check in `run_actions`
2024-04-14 22:10:37 -07:00
9dcf0a7d70
avm2: Resolve function argument types once when calling function for the first time
2024-04-14 22:10:37 -07:00
9870754b5e
avm2: Support optimization of `CallPropVoid` and virtual setters
...
This requires adding a custom field to the `CallMethod` op
2024-04-14 22:10:37 -07:00
Tom Schuster