2fd8f600bc
avm2: Correctly set XML attribute with namespace
2024-08-31 00:35:12 +02:00
795fa0df27
avm2: Throw special XML parsing error for unmatched end tag at the root level
2024-08-31 00:20:01 +02:00
9505da8438
core: use char slicing instead of byte slicing ( #17686 )
...
* core: use char slicing instead of byte slicing (close #17675 )
Fix a panic which can occur when pasting non-ASCII characters into a
textbox. Use char slicing instead of byte slicing when limiting the
length of the text being pasted in. This fixes issue #17675 .
* tests: Add test for issue 17675
* tests: fix incorrect output in test "avm2/issue_17675"
The output expected the text to be pasted at the end, even though it
will be pasted at the beginning, which is the correct behaviour here.
* core: use char length instead of byte length
Use char length instead of byte length for text pasting and setting the
current text selection.
* core: use WString for limiting text length and pasting text
Switch to WString from String for limiting text length and pasting text.
Done to ensure this code won't need to be fixed in the future. This does
not work properly with certain characters (e.g., 4-byte UTF-8 chars),
but that's due to how WString handles those characters.
* lint: fix clippy errors
---------
Co-authored-by: oad <48562304+oaddyk@users.noreply.github.com>
Co-authored-by: Adrian Wielgosik <adrian.wielgosik@gmail.com>
2024-08-30 23:49:50 +02:00
aff78a5d8e
build(deps): bump the cargo-minor group across 1 directory with 8 updates
...
Bumps the cargo-minor group with 8 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [flate2](https://github.com/rust-lang/flate2-rs ) | `1.0.31` | `1.0.33` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.208` | `1.0.209` |
| [bitstream-io](https://github.com/tuffy/bitstream-io ) | `2.5.0` | `2.5.3` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.125` | `1.0.127` |
| [quote](https://github.com/dtolnay/quote ) | `1.0.36` | `1.0.37` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.75` | `2.0.76` |
| [zip](https://github.com/zip-rs/zip2 ) | `2.1.6` | `2.2.0` |
| [reqwest](https://github.com/seanmonstar/reqwest ) | `0.12.6` | `0.12.7` |
Updates `flate2` from 1.0.31 to 1.0.33
- [Release notes](https://github.com/rust-lang/flate2-rs/releases )
- [Changelog](https://github.com/rust-lang/flate2-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/flate2-rs/compare/1.0.31...1.0.33 )
Updates `serde` from 1.0.208 to 1.0.209
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.208...v1.0.209 )
Updates `bitstream-io` from 2.5.0 to 2.5.3
- [Commits](https://github.com/tuffy/bitstream-io/compare/v2.5.0...v2.5.3 )
Updates `serde_json` from 1.0.125 to 1.0.127
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/1.0.125...1.0.127 )
Updates `quote` from 1.0.36 to 1.0.37
- [Release notes](https://github.com/dtolnay/quote/releases )
- [Commits](https://github.com/dtolnay/quote/compare/1.0.36...1.0.37 )
Updates `syn` from 2.0.75 to 2.0.76
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.75...2.0.76 )
Updates `zip` from 2.1.6 to 2.2.0
- [Release notes](https://github.com/zip-rs/zip2/releases )
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zip-rs/zip2/compare/v2.1.6...v2.2.0 )
Updates `reqwest` from 0.12.6 to 0.12.7
- [Release notes](https://github.com/seanmonstar/reqwest/releases )
- [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/seanmonstar/reqwest/compare/v0.12.6...v0.12.7 )
---
updated-dependencies:
- dependency-name: flate2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: bitstream-io
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: quote
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: zip
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: reqwest
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-26 14:04:51 +02:00
1344fe5f90
build(deps): bump wasm-bindgen-futures in the wasm-bindgen group
...
Bumps the wasm-bindgen group with 1 update: [wasm-bindgen-futures](https://github.com/rustwasm/wasm-bindgen ).
Updates `wasm-bindgen-futures` from 0.4.42 to 0.4.43
- [Release notes](https://github.com/rustwasm/wasm-bindgen/releases )
- [Changelog](https://github.com/rustwasm/wasm-bindgen/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rustwasm/wasm-bindgen/commits )
---
updated-dependencies:
- dependency-name: wasm-bindgen-futures
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: wasm-bindgen
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-26 13:14:35 +02:00
102e58b551
avm2: Throw when using delete with XMLList operand (name)
2024-08-26 12:57:47 +02:00
a4f03173c2
avm2: Make XML [[Delete]] follow the spec more closely
2024-08-26 12:57:47 +02:00
6ddc28edc4
avm2: Added all missing [API()] to classes from the list
2024-08-24 21:27:18 +02:00
bfd43297be
chore: Update translations from Crowdin
2024-08-24 00:52:55 +02:00
a10b31b118
avm2: For AIR report the correct OS in flash.system.Capabilities
2024-08-21 23:16:19 +02:00
73919c71c0
core: Make some avm1 object properties editable in debug ui ( #17279 )
2024-08-21 21:04:58 +00:00
6d2644ed48
avm2: support CSS comments and fix whitespace issues ( #17502 )
2024-08-21 20:34:03 +00:00
130430e805
avm2: XMLList needs to override has_own_property_string to handle
...
attributes
2024-08-21 22:18:29 +02:00
5834f273e2
avm2: Implement XML.removeNamespace
2024-08-21 20:51:52 +02:00
56f092be2e
desktop: Add "Exit Full Screen" option to context menu
...
This option allows the user to exit full screen
without knowing the Esc shortcut.
2024-08-21 14:31:56 +02:00
cd4eeb238f
avm2: Fix GraphicsPath.cubicCurveTo() [API()] version
...
Turns out, the docs were wrong again.
2024-08-20 22:17:22 +02:00
7178f3fd05
core: Refactor some code added in #15627
2024-08-20 19:51:17 +02:00
3e215610ca
core: managed `AvmStringRepr`s can now point to a `&'static WStr`
...
This allows `&'static WStr`s to be converted into interned `AvmString`s
without moving the string data into an heap-allocated buffer.
2024-08-20 16:02:41 +02:00
5b3c9722d5
build(deps): bump the cargo-minor group with 9 updates
...
Bumps the cargo-minor group with 9 updates:
| Package | From | To |
| --- | --- | --- |
| [clap](https://github.com/clap-rs/clap ) | `4.5.15` | `4.5.16` |
| [bytemuck](https://github.com/Lokathor/bytemuck ) | `1.16.3` | `1.17.0` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.207` | `1.0.208` |
| [tokio](https://github.com/tokio-rs/tokio ) | `1.39.2` | `1.39.3` |
| [indexmap](https://github.com/indexmap-rs/indexmap ) | `2.3.0` | `2.4.0` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.124` | `1.0.125` |
| [fluent-templates](https://github.com/XAMPPRocky/fluent-templates ) | `0.9.4` | `0.10.1` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.74` | `2.0.75` |
| [reqwest](https://github.com/seanmonstar/reqwest ) | `0.12.5` | `0.12.6` |
Updates `clap` from 4.5.15 to 4.5.16
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/clap_complete-v4.5.15...clap_complete-v4.5.16 )
Updates `bytemuck` from 1.16.3 to 1.17.0
- [Changelog](https://github.com/Lokathor/bytemuck/blob/main/changelog.md )
- [Commits](https://github.com/Lokathor/bytemuck/compare/v1.16.3...v1.17.0 )
Updates `serde` from 1.0.207 to 1.0.208
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.207...v1.0.208 )
Updates `tokio` from 1.39.2 to 1.39.3
- [Release notes](https://github.com/tokio-rs/tokio/releases )
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.39.2...tokio-1.39.3 )
Updates `indexmap` from 2.3.0 to 2.4.0
- [Changelog](https://github.com/indexmap-rs/indexmap/blob/master/RELEASES.md )
- [Commits](https://github.com/indexmap-rs/indexmap/compare/2.3.0...2.4.0 )
Updates `serde_json` from 1.0.124 to 1.0.125
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.124...1.0.125 )
Updates `fluent-templates` from 0.9.4 to 0.10.1
- [Release notes](https://github.com/XAMPPRocky/fluent-templates/releases )
- [Changelog](https://github.com/XAMPPRocky/fluent-templates/blob/master/CHANGELOG.md )
- [Commits](https://github.com/XAMPPRocky/fluent-templates/compare/fluent-templates-v0.9.4...fluent-templates-v0.10.1 )
Updates `syn` from 2.0.74 to 2.0.75
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.74...2.0.75 )
Updates `reqwest` from 0.12.5 to 0.12.6
- [Release notes](https://github.com/seanmonstar/reqwest/releases )
- [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/seanmonstar/reqwest/compare/v0.12.5...v0.12.6 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: bytemuck
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: tokio
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: indexmap
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: fluent-templates
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: reqwest
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-20 00:58:16 +02:00
cde0ef593c
avm2: Add comment for weird trig consts
2024-08-18 21:38:45 +02:00
db61726e5b
avm2: Implement Graphics::drawRoundRectComplex
2024-08-18 21:38:45 +02:00
f84fd985a8
avm2: Added all missing [API()] to methods from the list
2024-08-18 12:08:17 +02:00
0d37b3de8c
avm2: Ensure `bound_class` is set in `Activation::init_from_method` and remove special case for static methods in optimizer
2024-08-17 10:18:31 -07:00
7bea8c90ee
chore: appease clippy
2024-08-17 10:18:31 -07:00
cb5644bcb4
avm2: Fix some confusing naming of subclass and superclass
2024-08-17 10:18:31 -07:00
6507722f3e
avm2: Make Class class final
2024-08-17 10:18:31 -07:00
f68baf0f76
avm2: Fix many issues with supercalling methods
...
Supercalling on the global object now works;
supercalling in the class initializer now works; and
supercalling in static methods now uses the correct superclass.
2024-08-17 10:18:31 -07:00
24478ff43f
avm2: Add missing [API()] to flash.geom
2024-08-15 12:47:52 +02:00
fdd86c1da2
avm2: avoid enqueuing Sound.play an infinite amount of times ( #17425 )
2024-08-13 15:57:22 +00:00
3b9d9cf230
avm2: Pass in `Gc<'gc, BytecodeMethod<'gc>>` to `optimize`
...
This allows us to pretty-print a method name from within
`optimize` using `display_function` (which needs to do
`Gc::ptr_eq`)
2024-08-12 21:23:33 -04:00
953c6732cc
Fix extra class flash.display
2024-08-12 18:05:56 -07:00
7ed2bdb8b6
avm2: Ignore debug opcodes when checking has_simple_scoping
...
Previously, swfs with debug opcodes would never be able to
use the `has_simple_scoping` optimization, since we would fail
to match the getlocal0/pushscope sequence.
We now allow any number of interleaved debug opcodes when checking
for this pattern.
2024-08-12 20:14:45 -04:00
79817f41d8
avm2: Add `[API("674")]` to Rectangle.copyFrom
...
This fixes old classes that extend Rectangle and define `copyFrom`
without marking it as an override
2024-08-12 19:36:47 -04:00
9239cb8a5d
chore: A couple typo fixes in comments here and there
2024-08-12 21:36:51 +02:00
f51dcf8d55
build(deps): bump the cargo-minor group with 8 updates
...
Bumps the cargo-minor group with 8 updates:
| Package | From | To |
| --- | --- | --- |
| [clap](https://github.com/clap-rs/clap ) | `4.5.13` | `4.5.15` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.204` | `1.0.206` |
| [linkme](https://github.com/dtolnay/linkme ) | `0.3.27` | `0.3.28` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.122` | `1.0.124` |
| [syn](https://github.com/dtolnay/syn ) | `2.0.72` | `2.0.74` |
| [fontdb](https://github.com/RazrFalcon/fontdb ) | `0.20.0` | `0.21.0` |
| [async-io](https://github.com/smol-rs/async-io ) | `2.3.3` | `2.3.4` |
| [tempfile](https://github.com/Stebalien/tempfile ) | `3.11.0` | `3.12.0` |
Updates `clap` from 4.5.13 to 4.5.15
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/clap_complete-v4.5.13...v4.5.15 )
Updates `serde` from 1.0.204 to 1.0.206
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.204...v1.0.206 )
Updates `linkme` from 0.3.27 to 0.3.28
- [Release notes](https://github.com/dtolnay/linkme/releases )
- [Commits](https://github.com/dtolnay/linkme/compare/0.3.27...0.3.28 )
Updates `serde_json` from 1.0.122 to 1.0.124
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.122...v1.0.124 )
Updates `syn` from 2.0.72 to 2.0.74
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/2.0.72...2.0.74 )
Updates `fontdb` from 0.20.0 to 0.21.0
- [Changelog](https://github.com/RazrFalcon/fontdb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/RazrFalcon/fontdb/compare/v0.20.0...v0.21.0 )
Updates `async-io` from 2.3.3 to 2.3.4
- [Release notes](https://github.com/smol-rs/async-io/releases )
- [Changelog](https://github.com/smol-rs/async-io/blob/master/CHANGELOG.md )
- [Commits](https://github.com/smol-rs/async-io/compare/v2.3.3...v2.3.4 )
Updates `tempfile` from 3.11.0 to 3.12.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/commits )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: linkme
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: fontdb
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
- dependency-name: async-io
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: cargo-minor
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: cargo-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-12 16:45:39 +02:00
bf55f15913
avm2: Declare 'namespace AS3' and validate bytecode in playerglobals
...
In order for asc.jar to generate efficient bytecode
(a direct 'callproperty' instead of a dynamic namespace and method
lookup), we need to have 'namespace AS3' in each package where we
do a qualified 'obj.AS3::SomeMethod()' call.
I've adjusted `build_playerglobal` to scan all of our playerglobal
method bodies to ensure that we don't have the bad bytecode.
This uncovered several places where we were missing `namespace AS3'
Before this change, we were creating a new bound method within
all of our prototype methods in `XML/XMLList`, since they used
'self.AS3::SomeXmlMethod()' calls to delegate to the AS3 native
method.
This saves several hundred megabytes on
`https://s1106-r2game-sq.7road.net `, since we no longer create
bound `FunctionObject`s for all of the distinct XML/XMLList objects
that the swf creates.
2024-08-11 17:33:46 -04:00
3b93ff941e
avm2: Intern XML node name
2024-08-11 09:56:02 +02:00
c3529afe11
avm1: Math tests: Substitute some trivial expected values and add TODOs about @epsilon
2024-08-11 02:15:36 +02:00
3573322c6d
avm1: Change expected values in `test_exp` math test to the exact ones returned by FP
...
And add some tolerance to make it pass with both current stable/beta and nightly rustc.
Thanks for figuring out the precise values, @kjarosh!
2024-08-11 02:15:36 +02:00
056501ee75
avm1: Add a way to specify numeric tolerance `@epsilon` when comparing in `test_method!`
2024-08-11 02:15:36 +02:00
47030b4f5b
core: remove UpdateContext's unused lifetime and reborrow method
2024-08-10 22:53:27 +02:00
13cffa4c94
core: appease clippy
2024-08-10 22:53:27 +02:00
d07437e30e
core: store 'gc borrows in UpdateContext, and `&mut UC` in Activation
...
This leaves the second UpdateContext lifetime unused and the `reborrow`
method useless, but they're kept to avoid an unnecessarily huge diff.
2024-08-10 22:53:27 +02:00
d116ef82e9
core: rework the way the garbage-collected arena is entered in `Player`
...
Add `Player::enter_arena(_mut)` methods, giving more ergonomic access to
the GC'd arena by:
- handling the RefCell borrows for you;
- passing an extra `&(mut) Player` parameter into the closure;
- giving all borrows the same `'gc` lifetime (thanks to strategic `unsafe`).
2024-08-10 22:53:27 +02:00
0b3395d21f
core: simplify callstack handling in Player
...
Grab the AVM2 callstack handle before constructing the GC root,
so that we can set it directly instead of modify the GC root once
constructed. This means we can remove an extra GcCell.
Also switch the callstack object from GcCell to GcRefLock.
2024-08-10 22:53:27 +02:00
0097aea381
avm2: Make primitive coercions way cheaper
2024-08-10 17:24:31 +02:00
f202088bd8
avm2: Box E4XNamespace in E4XNodeData
2024-08-10 15:28:28 +02:00
637b1ccf4e
avm2: Save an alloc when calling Regexp effective_replacement with no replacement patterns
2024-08-10 01:53:01 +02:00
0023062c82
avm2: Short circuit the regexp replacement logic if it's a simple (no pattern) string
2024-08-10 01:53:01 +02:00
ef42bba20c
avm2: Don't realloc the same string in Regexp.replace_with_fn, if no match was found
2024-08-10 01:53:01 +02:00
Tom Schuster