liangsheng8708
/
ruffle
mirror of https://mirror.ghproxy.com/https://github.com/ruffle-rs/ruffle.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

extension: Prefer functions over methods 

TypeScript is more strict with functions. Fix 2 instances affected
by this change.
This commit is contained in:
relrelb 2021-10-02 00:04:01 +03:00 committed by relrelb
parent b250dd5ff1
commit f3a482a48f
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
web/packages/extension/src/utils.ts
View File

@ -9,46 +9,46 @@ const DEFAULT_OPTIONS: Options = {
}; };
export let i18n: { export let i18n: {
getMessage(name: string): string; getMessage: (name: string) => string;
}; };
interface StorageArea { interface StorageArea {
get(keys?: string[]): Promise<Record<string, unknown>>; get: (keys?: string[]) => Promise<Record<string, unknown>>;
remove(keys: string[]): Promise<void>; remove: (keys: string[]) => Promise<void>;
set(items: Record<string, unknown>): Promise<void>; set: (items: Record<string, unknown>) => Promise<void>;
} }
export let storage: { export let storage: {
local: StorageArea; local: StorageArea;
sync: StorageArea; sync: StorageArea;
onChanged: { onChanged: {
addListener( addListener: (
listener: ( listener: (
changes: changes:
| Record<string, chrome.storage.StorageChange> | Record<string, chrome.storage.StorageChange>
| Record<string, browser.storage.StorageChange>, | Record<string, browser.storage.StorageChange>,
areaName: string areaName: string
) => void ) => void
): void; ) => void;
}; };
}; };
export let tabs: { export let tabs: {
reload(tabId: number): Promise<void>; reload: (tabId: number) => Promise<void>;
query( query: (
query: chrome.tabs.QueryInfo & browser.tabs._QueryQueryInfo query: chrome.tabs.QueryInfo & browser.tabs._QueryQueryInfo
): Promise<chrome.tabs.Tab[] | browser.tabs.Tab[]>; ) => Promise<chrome.tabs.Tab[] | browser.tabs.Tab[]>;
sendMessage( sendMessage: (
tabId: number, tabId: number,
message: unknown, message: unknown,
options?: chrome.tabs.MessageSendOptions & options?: chrome.tabs.MessageSendOptions &
browser.tabs._SendMessageOptions browser.tabs._SendMessageOptions
): Promise<any>; // eslint-disable-line @typescript-eslint/no-explicit-any ) => Promise<any>; // eslint-disable-line @typescript-eslint/no-explicit-any
}; };
export let runtime: { export let runtime: {
onMessage: { onMessage: {
addListener( addListener: (
listener: ( listener: (
message: unknown, message: unknown,
sender: sender:
@ -56,9 +56,9 @@ export let runtime: {
| browser.runtime.MessageSender, | browser.runtime.MessageSender,
sendResponse: (response?: unknown) => void sendResponse: (response?: unknown) => void
) => void ) => void
): void; ) => void;
}; };
getURL(path: string): string; getURL: (path: string) => string;
}; };
export let openOptionsPage: () => Promise<void>; export let openOptionsPage: () => Promise<void>;
@ -82,7 +82,8 @@ function promisifyStorageArea(
storage: chrome.storage.StorageArea storage: chrome.storage.StorageArea
): StorageArea { ): StorageArea {
return { return {
get: (keys: string[]) => promisify((cb) => storage.get(keys, cb)), get: (keys?: string[]) =>
promisify((cb) => storage.get(keys || null, cb)),
remove: (keys: string[]) => promisify((cb) => storage.remove(keys, cb)), remove: (keys: string[]) => promisify((cb) => storage.remove(keys, cb)),
set: (items: Record<string, unknown>) => set: (items: Record<string, unknown>) =>
promisify((cb) => storage.set(items, cb)), promisify((cb) => storage.set(items, cb)),
@ -113,10 +114,10 @@ if (typeof chrome !== "undefined") {
sendMessage: ( sendMessage: (
tabId: number, tabId: number,
message: unknown, message: unknown,
options: chrome.tabs.MessageSendOptions options?: chrome.tabs.MessageSendOptions
) => ) =>
promisify((cb) => promisify((cb) =>
chrome.tabs.sendMessage(tabId, message, options, cb) chrome.tabs.sendMessage(tabId, message, options || {}, cb)
), ),
}; };