avm1: Simplify `SuperObject::from_this_and_base_proto`

core/src/avm1/function.rs

@@ -268,14 +268,7 @@ impl<'gc> Executable<'gc> {
                 let argcell = arguments.into();
                 let super_object: Option<Object<'gc>> =
                     if !af.flags.contains(FunctionFlags::SUPPRESS_SUPER) {
-                        Some(
+                        Some(SuperObject::new(activation, this, base_proto.unwrap_or(this)).into())
-                            SuperObject::from_this_and_base_proto(
-                                this,
-                                base_proto.unwrap_or(this),
-                                activation,
-                            )?
-                            .into(),
-                        )
                     } else {
                         None
                     };

core/src/avm1/object/super_object.rs

@@ -35,18 +35,18 @@ impl<'gc> SuperObject<'gc> {
     /// Construct a `super` for an incoming stack frame.
     ///
     /// `this` and `base_proto` must be the values provided to `Executable::exec`.
-    pub fn from_this_and_base_proto(
+    pub fn new(
+        activation: &mut Activation<'_, 'gc, '_>,
         this: Object<'gc>,
         base_proto: Object<'gc>,
-        activation: &mut Activation<'_, 'gc, '_>,
+    ) -> Self {
-    ) -> Result<Self, Error<'gc>> {
+        Self(GcCell::allocate(
-        Ok(Self(GcCell::allocate(
             activation.context.gc_context,
             SuperObjectData {
                 child: this,
                 base_proto,
             },
-        )))
+        ))
     }
 
     /// Retrieve the constructor associated with the super proto.