From da0b245fb8dc2e1c73beba8eb0e956506ca1ba44 Mon Sep 17 00:00:00 2001
From: yoganlava <udeshya@hotmail.co.uk>
Date: Tue, 21 Mar 2023 22:10:21 +0000
Subject: [PATCH] avm2: Fully implement XML.elements()

---
 core/src/avm2/globals/xml.rs                  |  16 ++++++++++++++--
 tests/tests/swfs/avm2/xml_elements/Test.as    |   5 +++++
 tests/tests/swfs/avm2/xml_elements/output.txt |   3 +++
 tests/tests/swfs/avm2/xml_elements/test.swf   | Bin 952 -> 1050 bytes
 4 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/core/src/avm2/globals/xml.rs b/core/src/avm2/globals/xml.rs
index c1436ceab..b255fbad8 100644
--- a/core/src/avm2/globals/xml.rs
+++ b/core/src/avm2/globals/xml.rs
@@ -164,13 +164,25 @@ pub fn parent<'gc>(
 pub fn elements<'gc>(
     activation: &mut Activation<'_, 'gc>,
     this: Option<Object<'gc>>,
-    _args: &[Value<'gc>],
+    args: &[Value<'gc>],
 ) -> Result<Value<'gc>, Error<'gc>> {
     let xml = this.unwrap().as_xml_object().unwrap();
+    let element_name = if args[0] == Value::Undefined {
+        AvmString::from("*")
+    } else {
+        args[0].coerce_to_string(activation)?
+    };
+    let is_asterisk = element_name == AvmString::from("*");
     let children = if let E4XNodeKind::Element { children, .. } = &*xml.node().kind() {
         children
             .iter()
-            .filter(|node| matches!(&*node.kind(), E4XNodeKind::Element { .. }))
+            .filter(|node| {
+                if is_asterisk {
+                    matches!(&*node.kind(), E4XNodeKind::Element { .. })
+                } else {
+                    matches!(&*node.kind(), E4XNodeKind::Element { .. }) && node.local_name().unwrap() == element_name
+                }
+            })
             .map(|node| E4XOrXml::E4X(*node))
             .collect()
     } else {
diff --git a/tests/tests/swfs/avm2/xml_elements/Test.as b/tests/tests/swfs/avm2/xml_elements/Test.as
index d094706a0..c6dce3ce6 100644
--- a/tests/tests/swfs/avm2/xml_elements/Test.as
+++ b/tests/tests/swfs/avm2/xml_elements/Test.as
@@ -9,3 +9,8 @@ trace('elements() length: ' + xml.elements().length());
 for each (var element in xml.elements()) {
   trace('elements() element toString: ' + element.toString());
 }
+
+var xml2 = new XML("<x><foo>foo</foo><foo>bar</foo><bar>bar</bar></x>")
+trace('elements(foo) length: ' + xml2.elements("foo").length());
+trace('elements(bar) length: ' + xml2.elements("bar").length());
+trace('elements(baz) length: ' + xml2.elements("baz").length());
\ No newline at end of file
diff --git a/tests/tests/swfs/avm2/xml_elements/output.txt b/tests/tests/swfs/avm2/xml_elements/output.txt
index b7e955a4c..10cf7f029 100644
--- a/tests/tests/swfs/avm2/xml_elements/output.txt
+++ b/tests/tests/swfs/avm2/xml_elements/output.txt
@@ -1,3 +1,6 @@
 elements() length: 2
 elements() element toString: foo1
 elements() element toString: bar2
+elements(foo) length: 2
+elements(bar) length: 1
+elements(baz) length: 0
diff --git a/tests/tests/swfs/avm2/xml_elements/test.swf b/tests/tests/swfs/avm2/xml_elements/test.swf
index 79922c9e70f70de093ff12de09d5df70d5295d66..845010cfd84ff363766ab20a110bc3c2d1a172c0 100644
GIT binary patch
literal 1050
zcmV+#1m*ifS5qcy1^@tf0fkgSbK67|-qp&I<;ICaikkodhXg{0$g-6t5LZ=`i7}L+
zq*J#;hq1>aODkJcmORorc6(u_7ybq({st!w+yV^r#-SHDnm<5zE8B5$!s93Je((Ff
zeY^YQ5fWb^wD<!;s~A<6*APPAuKa}&G9t&VJgn9Vqn;nc6`0-G?lRV|XxeZ%EDm>z
zVbsye2L}gQN!N5;1%?_w3z#)hgLre>Obn_twj;04yf7$mL#rJQ*q!a|sjFjOnDz&e
zpIAD!Mt$0&0gJVAu?$9zU2(&xXED?2_kGW{xScjq<8Ej_9a^VUb$u)D8rq!5HOyl^
zHIMq1-KB+^Pe+BLxjZ3H7@X_O>oljkbU{(H5_M8nqPWcCy8fW;dvTXWvvumB%Z642
z3x<QhNh(c*b0U}75w%$OzoHq9OMENn46F_{Y0!FHPdqQ6WCs?bre0R>Tal`l^xa9h
z95gh3@|SL6iooTXXfZcf`|?D6a8$2<b@H%^&X%A9u6(Mwzlnj4h4b_CuQLQv5`>t0
z`tvSy2}0S8J?T3b{gin`V}^db{x5KNCYk0?k(0K?WcKK|(s&%xC~gekAiIrfXb+N$
zZaj#>Z>Y`UMl^8Y;2R9Q;^{LUx^crg?dc6@#n!AhZr|pXMJrbLuf`wQqz#IW7x#VZ
znN;sb9;4Dpn>#Okata+)g_OmhAEJc`mvS`DavUTR>hisS(a5rycS<Kn{!0EhgeLa_
z8j&aWzo;1_)41yeF^dMEfHuEt8XKxw7>x?5YPNj~zJ?oyCPdlL_{eBmkqMz28Xp<j
z$V@R<kgm)&_rcAAPlFEYRto7EmYgr_cS}Fmn6{|pgl$^1!=83j-_`U|X<us(JfC@i
zG?A~*#9%lb7Fbwkkr#BpdNwTcO-yT?mdIyN+|`2T_2w^(fjBRgz-*oZ{iPJlE~lPf
zNj<;OYIVXE3tJ9#y};uq+3HfiPx@gj?Cle{dg0@b<ms|RzqKy{q?6rSd+8L;3;EP4
z&MT?c(klWHBsnJwSSFGz$Z{$zlZ;HR$z(wmva+zGEMw(5R`OVuHe_j2mfnMo6`)H+
z2my(2<97-W??P-rypOS<h)GLhLBv%I!|WmOF<w06y)G;rf)Wz~NLnFhrB8VdE1Aq$
z>Fgf*hm4m25kwKEU*WS7%n3zJ;*wHRbj4CL<)%ta$(2e?*_BI8!4;Cn6SSUux)>Bv
zGrhC;c^W$(_JpzARCaQXFVr%qb`5=BQ}E5PvW5PbKrdeA;9p$%?bl5plW_*fuRA`e
zEzFoY5tjcvKTngiFwTPSjft-~UIgl@<BL0MwG6&+UIO$Dj=p&r%>nurN7v`*i{F3w
UEDf)|vU2hMAHtFT2YB4t2u;TS@Bjb+

literal 952
zcmV;p14sNrS5qc_1poke0fke`Zrer_orlDS;)h(Pj@{M;0|#&)mPpgBTiXm{BZ}Gt
zNnJ!O8Wa$O5jm9DP$WT)EM-+7i=sbKpsW5x(N!1SxzFsg%F_J;_YNi5$*P3z=+2#U
z4rlHhj#243LJL13w2Dz<X$>Lt?eYtZkdyhr{=-Jo7!RU2--p@F&At%nzG;p|qxxv4
zo@709dv9;gv~1J1Yk;WbPh!EwwK(6{bPIt7&%G>6MVQ2f6lC3GC~j_UPE~#HLNpy_
zQ6cGjCXe`l$09ek>)RmYd;39>4VZ9Qnnt0=q?|df<^9BaJYpxj7DO!XJLV-&azrR1
z?jEJg>vN+S@v(7qNiV<?gv9!n`*f$L41iH*1-sZ+!FU-bdFiklg?XQ6v-h-;K#W)h
zFHDB9U+lCXUIHb}%QzFs|B_}fNr_n88?qjEdEEK3RcKz6iW4xw-3Kf)w(Tv$w(OnB
zer44$W$RzMifILI*F_7};o4`%wa<@Qt*?$BHqhxJSm2eXQGG!jbeo)?pMPDUu%tkg
zs*iu$0h=K7{lU-AzJu)7$`?Er=$ETiz{r(iT19mUdb?E2?wI{#z)g`1%rr~B;U3&^
zHVmNErT}t29rIC;o9tv@n_#}q%nb(zQlrjtUH+SLm@h8A?uU6Au_sC^%|gMI<E~U*
zymJB`YQPc`;DBsyg5|QB&&xVcCeWq3vEUi=M0mm{m6cc4Zzo{uFy<M3^x%He8N1G{
zFwR9b1O^!Umg`)v)r|4jsMXwV#Ng)yN#a6mJEqK>F3Vg9+c9P4m}9pr;Dvm7cDQ%m
zH6kAOM1SAVX0@WBaNZmC-u0;|nV)od-GlxewRTL~vUbhxFpNYPD--(qj0}R))DTHa
zWMSL`=~;TM)9EE0k#u|>gmEa3(dqLjrD>9r4|gf_oqYU}I#r<d2fJDsuaK4UDqhjc
zuW8GK5=C8930A415>+j0Dy^vWic05HGOv<FeF^JVvA%*;<qcJN3p_!<2PFuC=rz2$
z2Jt4uI>tmV6^6lt;s%Cv{t&PjFC0oI5eliM(^KmcS;Ts!a%!F4MgP*XIj9g?#@Y|~
z)PgzXs7(WEwM#+CYL|nu)m8$<YO8^2wMjsV;SpLdo<0VK($=;X?rGS6e?ZREw!T&M
zBhsv(<`wi~Q^!yLKGScYe<ro3&#D^;>3{yQ@t#)#0_~Qx5+Eu-d)<#{bMAs;Q?m5e
a`ME|l^82S6d<^>X#TRi1E%*<<N|vVcWZ?Gz