extension: Address review comments

This commit is contained in:
Daniel Jacobs 2024-06-21 16:45:25 -04:00
parent eb64cd530d
commit cee3046216
1 changed files with 2 additions and 12 deletions

View File

@ -94,13 +94,7 @@ export async function getExplicitOptions(): Promise<Options> {
export const hasAllUrlsPermission = async () => { export const hasAllUrlsPermission = async () => {
const allPermissions = await permissions.getAll(); const allPermissions = await permissions.getAll();
if (Object.prototype.hasOwnProperty.call(allPermissions, "origins")) { return allPermissions.origins?.includes("<all_urls>") ?? false;
return (
allPermissions.origins &&
allPermissions.origins.indexOf("<all_urls>") > -1
);
}
return false;
}; };
export async function hasHostPermissionForActiveTab() { export async function hasHostPermissionForActiveTab() {
@ -110,11 +104,7 @@ export async function hasHostPermissionForActiveTab() {
}); });
try { try {
return activeTab?.url return activeTab?.url ? true : await hasAllUrlsPermission();
? await permissions.contains({
origins: [activeTab.url],
})
: await hasAllUrlsPermission();
} catch { } catch {
// catch error that occurs for special urls like about: // catch error that occurs for special urls like about:
return false; return false;