From c7c025277fd146c593969ae3382587d8b6020f3b Mon Sep 17 00:00:00 2001
From: paq <89paku@gmail.com>
Date: Sat, 6 Feb 2021 19:50:08 +0900
Subject: [PATCH] avm2: Implement String.charAt

---
 core/src/avm2/globals/string.rs               |  37 ++++++++++++++++++
 core/tests/regression_tests.rs                |   1 +
 core/tests/swfs/avm2/string_char_at/Test.as   |  32 +++++++++++++++
 .../tests/swfs/avm2/string_char_at/output.txt |  28 +++++++++++++
 core/tests/swfs/avm2/string_char_at/test.fla  | Bin 0 -> 4031 bytes
 core/tests/swfs/avm2/string_char_at/test.swf  | Bin 0 -> 1288 bytes
 6 files changed, 98 insertions(+)
 create mode 100644 core/tests/swfs/avm2/string_char_at/Test.as
 create mode 100644 core/tests/swfs/avm2/string_char_at/output.txt
 create mode 100644 core/tests/swfs/avm2/string_char_at/test.fla
 create mode 100644 core/tests/swfs/avm2/string_char_at/test.swf

diff --git a/core/src/avm2/globals/string.rs b/core/src/avm2/globals/string.rs
index 629061996..889069bb5 100644
--- a/core/src/avm2/globals/string.rs
+++ b/core/src/avm2/globals/string.rs
@@ -4,9 +4,11 @@ use crate::avm2::class::{Class, ClassAttributes};
 use crate::avm2::method::Method;
 use crate::avm2::names::{Namespace, QName};
 use crate::avm2::object::{Object, TObject};
+use crate::avm2::string::AvmString;
 use crate::avm2::value::Value;
 use crate::avm2::Error;
 use crate::avm2::{activation::Activation, traits::Trait};
+use crate::string_utils;
 use gc_arena::{GcCell, MutationContext};
 
 /// Implements `String`'s instance initializer.
@@ -54,6 +56,36 @@ fn length<'gc>(
     Ok(Value::Undefined)
 }
 
+/// Implements `String.charAt`
+fn char_at<'gc>(
+    activation: &mut Activation<'_, 'gc, '_>,
+    this: Option<Object<'gc>>,
+    args: &[Value<'gc>],
+) -> Result<Value<'gc>, Error> {
+    if let Some(this) = this {
+        if let Value::String(s) = this.value_of(activation.context.gc_context)? {
+            // This function takes Number, so if we use coerce_to_i32 instead of coerce_to_number, the value may overflow.
+            let n = args
+                .get(0)
+                .unwrap_or(&Value::Number(0.0))
+                .coerce_to_number(activation)?;
+            if n < 0.0 {
+                return Ok("".into());
+            }
+
+            let index = if !n.is_nan() { n as usize } else { 0 };
+            let ret = s
+                .encode_utf16()
+                .nth(index)
+                .map(|c| string_utils::utf16_code_unit_to_char(c).to_string())
+                .unwrap_or_default();
+            return Ok(AvmString::new(activation.context.gc_context, ret).into());
+        }
+    }
+
+    Ok(Value::Undefined)
+}
+
 /// Construct `String`'s class.
 pub fn create_class<'gc>(mc: MutationContext<'gc, '_>) -> GcCell<'gc, Class<'gc>> {
     let class = Class::new(
@@ -72,5 +104,10 @@ pub fn create_class<'gc>(mc: MutationContext<'gc, '_>) -> GcCell<'gc, Class<'gc>
         Method::from_builtin(length),
     ));
 
+    write.define_instance_trait(Trait::from_method(
+        QName::new(Namespace::as3_namespace(), "charAt"),
+        Method::from_builtin(char_at),
+    ));
+
     class
 }
diff --git a/core/tests/regression_tests.rs b/core/tests/regression_tests.rs
index 003a2ccff..0cfbafe18 100644
--- a/core/tests/regression_tests.rs
+++ b/core/tests/regression_tests.rs
@@ -506,6 +506,7 @@ swf_tests! {
     (as3_movieclip_dispatchevent_selfadd, "avm2/movieclip_dispatchevent_selfadd", 1),
     (as3_string_constr, "avm2/string_constr", 1),
     (as3_string_length, "avm2/string_length", 1),
+    (as3_string_char_at, "avm2/string_char_at", 1),
 }
 
 // TODO: These tests have some inaccuracies currently, so we use approx_eq to test that numeric values are close enough.
diff --git a/core/tests/swfs/avm2/string_char_at/Test.as b/core/tests/swfs/avm2/string_char_at/Test.as
new file mode 100644
index 000000000..954f523ad
--- /dev/null
+++ b/core/tests/swfs/avm2/string_char_at/Test.as
@@ -0,0 +1,32 @@
+package {
+	public class Test {}
+}
+
+trace("//\"abcdefg\".charAt();")
+trace("abcdefg".charAt());
+trace("//\"abcdefg\".charAt(1);")
+trace("abcdefg".charAt(1));
+trace("//\"abcdefg\".charAt(1.1);")
+trace("abcdefg".charAt(1.1));
+trace("//\"abcdefg\".charAt(1.5);")
+trace("abcdefg".charAt(1.5));
+trace("//\"abcdefg\".charAt(7);")
+trace("abcdefg".charAt(7));
+trace("//\"abcdefg\".charAt(-1);")
+trace("abcdefg".charAt(-1));
+trace("//\"abcdefg\".charAt(NaN);")
+trace("abcdefg".charAt(NaN));
+trace("//\"abcdefg\".charAt(1.79e+308);")
+trace("abcdefg".charAt(1.79e+308));
+trace("//\"abcdefg\".charAt(Infinity);")
+trace("abcdefg".charAt(Infinity));
+trace("//\"abcdefg\".charAt(-Infinity);")
+trace("abcdefg".charAt(-Infinity));
+trace("//\"あいうえお\".charAt(1);")
+trace("あいうえお".charAt(1));
+trace("//\"مَرحَبًا\".charAt(1);")
+trace("مَرحَبًا".charAt(1));
+trace("//\"👨‍👨‍👧‍👦\".charAt(0);")
+trace("👨‍👨‍👧‍👦".charAt(0));
+trace("//\"\".charAt(0);")
+trace("".charAt(0));
diff --git a/core/tests/swfs/avm2/string_char_at/output.txt b/core/tests/swfs/avm2/string_char_at/output.txt
new file mode 100644
index 000000000..c8832200c
--- /dev/null
+++ b/core/tests/swfs/avm2/string_char_at/output.txt
@@ -0,0 +1,28 @@
+//"abcdefg".charAt();
+a
+//"abcdefg".charAt(1);
+b
+//"abcdefg".charAt(1.1);
+b
+//"abcdefg".charAt(1.5);
+b
+//"abcdefg".charAt(7);
+
+//"abcdefg".charAt(-1);
+
+//"abcdefg".charAt(NaN);
+a
+//"abcdefg".charAt(1.79e+308);
+
+//"abcdefg".charAt(Infinity);
+
+//"abcdefg".charAt(-Infinity);
+
+//"あいうえお".charAt(1);
+い
+//"مَرحَبًا".charAt(1);
+َ
+//"👨‍👨‍👧‍👦".charAt(0);
+�
+//"".charAt(0);
+
diff --git a/core/tests/swfs/avm2/string_char_at/test.fla b/core/tests/swfs/avm2/string_char_at/test.fla
new file mode 100644
index 0000000000000000000000000000000000000000..d382fbe3e8ab454910c617c4d2ff9d879207277d
GIT binary patch
literal 4031
zcmbtXc{r5&7oTj6ELlUAjD74B2HCePWwH%f24gH4>loSB$&w{y2~C#Bnk`Wm(M;JR
zLW)G9g&1VXSo+P}?ycK>>i+XP^PK1XzVG*Z&i6d?p7TDR57d;Jh64Zq0stXZ)=+*X
zH)?tS06=l_BR~)m9V8p#j)Gd4+uF(KSt>z)3MWT=H%hpfv95)Vg`M2*qbP|_8(8Vc
z7@slxk1$qpm_No9<%RYPLi+flT*!s|6;1^N{#ojAc6)C=Y5-uF0RT8m4%at7t?!4x
z_#l1B75ku?a_r3~<vF^iuY6&4+PtH2Hvp$zdWznw*+gD4+ff8tb^?Q!ZYX(iYe{nt
zXUdRzH%4eJ>kIC)y7>FurN<0%gL*mAie|L7NbtOo)ET<I8kX%VRkGLm_brHxvxWvN
z=NIZeHyQ_~G~PFo;8HkUZ(-ykEJ5r(uH3nYMJ}8#$O%ZVig7#3q1Y|j>u(|<Ad#Pn
zE7$VJ)0a@wZaCV@iqfXjN*M+X(p`eb#h4o(VaSs(M<{q0C_|&z)DWh%F*|B)!G({v
zLg>mCPt$n50>niE%NVW>0(A4|B?ME5wyPPul1<x_Lf2<?Wk;P*VTtT`@e_k`qR|57
z4mmojCT47AtDa);q$kFlXS46M_goZNYiQFzNKbd|dhm9u<PsGP4R9`6l?C@S(N|p?
z23M~UOZ<zlAjU_6Nn!5tsbL8`MFqT|lJ|>4{<?Ga&75NjO<$oSiC3r{m#lbo$AMJp
z*r=jy9gc?|tPW>qKB9&?6?ndTq$0I($Ew#oFs5(Kt+AgOpsHY}AghZ@nFOVkgA15A
z&Pvy>(LgOFVf(M@2Lf!=PS98FOy3f*?Q=`i(&g^;t}Yd05{!tmR4vm;J|>!XZD7ip
zFydOJ3IK!Jj!Ia7qE|?`0XJlA8t#FeKtR5#7;SIoqVB?dF~W{N<|ygfK4)*B4bVUN
z4~XVT$jPD*JB<iZL_}odY^7iCOr>94U#5oaQ($fTD|O6B+k;H#R{G62D>l#JD-%Mc
zlFlW=HMlX4FkiKu6@l0H1+8XW<1PxWzq<m0n^_Y4I@n~*OE*SPZzq)5Ak=Bo*xl^e
zdNXjg`z>iBfuORI$swgH?Mm2?miu0FRqaPUEmP^$@V-!<#3xX<#`Yh-%Zd79>S0+k
zH7aPa;f?K6{HY79Ct9pg5JM?j^yyY%?xuMD*6WgtlRmV1{q<@#uWr6&Lmf3#sUIUR
zQj10!X8D~5BIV>4nm;p^Bj1Cj0_MT%0%|$VqnP*?OU}v56_=jN$l%X)3)t6iE(X5E
zyb`qWzKrR<1BXnV+;}NoO_KJFS~1^0@NGP){+fC6?0h#)^6L9|`XGZ`++2cODC6`u
z<lF4EW!@0nJqQ3)@BskqWC--zs9GX}g1me^&=f$YouA(<ggrXCkg9m3ME#>DeJm9N
zFZklK&9ff^O}E12G9*<LW_*&+>ENX(lE<#xW4auh*03|#`FVxi#|u_Ny6E>p<JRW&
zx<24UAcvzq+H24AG~$NV5o79=Fe&i4H<!mi1tl0lb++dK_nGZ(Ne^!arl?9QQsxFi
zcWplD4(BYp;qfOBd?;=C2L*h9F$WfL>%)<|?_$TbnnFZ{V8UG-#oD&7V0;06%f?4X
zcgl|tlTy#RB?Fz3rMD$n^XDyf7!<h(v&AuWJWfD;&8Bx&LgbqWVVR^vDv5LS+9yrU
zFy0&F+|O!o9LMn_CIs_qo*3qtNWkaK=o<L*sUCcp@Z<`*SSVvzcSOUL1!nX_=Tecn
zE3?JKC04iQ$B@Bo<MzD8C5e@(2leGMTqt69aUM%RxLBWJxE?M~Xnm70wn8RAA4F;v
z0R)=!sj^1euXr~@ug}V=V`vU!w9fY6>F$G4=b9mb_0-LLfIzrI>-^2LAgJhWN~8R`
z{Z#%jQvA8b5zq0#$qnC{NuPU96Cb%ixN)#~1!;4QisjvinY8?k#tA#`(F!GA0nfF?
zfe8szFx`?(WB4$t9p-3Mq0YV#0k2Y*s`SQ8m)9yR5O#w-<{m9%wd7cgZx^)ee~b;Y
zukD0osC7%O!mFMfR!D54nGF-r6ut^HcKH(iC?{?)=nQqos*&UF#%_z)QI7;q9)b$i
z11S6n!!)d*KgnWvdHe)+_$^OK!IsfD3%}l7rU3V(98iA33e&JWwmhkYr|MD0_!=j@
zq;|bHDwGNOjJ-<)l$uPtiEU5@u45aHq;6pqSPKe<Bmgc9j7njWj81jHX2x5GmapMB
zvIDd&nKfXzA}g*IA`?*($ewO@38Go*3eyG$Sf{Y>v4Ekl%Dv|oIQuGl9)_)fS_6Fw
zl`EBG?*x90$)6)wz`q8`-FAPKnJX7>!@wbBfrsTv=bZF>eqj9W>Luy9B|X-#8t|Jx
z9IlISgy?yR#Yq<)$`5?}g{B70$M8|HnpUV3XN7fQK+f@ExkaD7JESYKz8s%o*=szP
zM2s`}@>IzL7|oQwXQ@{e3yL!HT-SFy7BiEKTyhpm@-kCF9PMwq2B}G&vx{@;hB&5V
zXW1bZ^7KP!1|@`P%M*wzhr}vsGWQTGE}No>pA}PtH}&0Ja+p|+8hH=x4-j%SXYF#?
zB+~9bt58`uj?;|D8x%bK-mSs?)aad;V^d$;%h2%h*>wJ?t(+iq;*qVSTW=#kbwbJ(
zvc17Cn`FCZYXfczO%J0^setEh7jtL|F$%3w-7n_Y=kdtut?)9zI~$IoVtFl&Wu#_u
zZqpsL4FM(iXfxCRI}j3tV(A^l#tZW5;c6SlP8EVZxP1>+b!^W%WPQ2Q6H}|0fDZBY
z<gKK#2;_QtlZ7+C4`uxD8A4c%YK7|YsnqhI8(n?TybTlZq4gA!&y%*Ez)Um2VZ3?M
z*40g3@uESV@g{?W;G+sx14@`r5aTzLOFq!ctaPTlAhC{EM;<<(Y|a9IrvoateGpga
zS1j&46?;ergPVySjK`Nx4sXmS9xl1=AGW~~^+zjdeVeqo_BMLo&hj-oeQia-D6GIv
zq(7`7rY+Z*F1f2%Fig?WVU*J-w7poGxsO11e9v_0Q?4dEj{tA|MZvol>hf;8%9hg9
zjd)yThul*MoYuY(pT&^>B-_Wp5~W&LoP;ST16DEbGh&Q3u#wcaUQHeMkn?SkXz%1B
ztd^ehz<<O%^OOn01J*1{u>)N8OesQD`KUY#fg(@vgpm%H-kbapP&(UV`Mb}S^RmG4
z7w0mxJE&{4O+b&hsLrITp8~n}<>i2F(UP56m0{><#j>qS)XMXVAH0&@*wQ(fuDcvO
z;l(1l$o*BLpn^jJGS$GEqA~;LHh|!(-T*VhS6!E&B1b}p))yoPFDY${?2Iynx+Oh$
zoneLRj+syHsfpBUQ8)7wV-)A;%uQ2(KZCrGr>VOcP8aN9Ml{0Lb?Bh2-)~%~X0hJQ
zB!Q&`wX6w;PboWa!~CAt3Pp-rRC8qOgJMJvRU-k<1-D*Q^H>mZfipe2+D5W)gY1>y
zsGDya2&e;cL}S&HH@%N3GLI`?sB~X#p?RNPL=Ep*jygEmM$nZiO=igJPkU$DgyL#^
zP5P9gzn#7c4{6m3?hGNOajna^fg-v{nrG|PRK>@28kaEVrsztA<w+-#(c+R5o4fq&
zGO4VWbM6Qo?lqz5r|Vmu)XaI%A@aF!sjc0xPts|~&v9-48bF7+h_ffG1sODClNGo<
zZ)w@}ygx=PYhI^hj4g-Jo;h_sN>w&<vcHi3nu==l!#p%05klQOd|QLf=_O11ZLD##
z{@#e|C;lk=<?OwEtc}(rF_yF`)5`oJdyD>{Vw`HZ6h5U@AOArZ6Apf@;O28c#ROMN
z&v+}8E=?%SsWT!)uGKfx(`WlRQ6<`TWO}>!98C9!%$pdPRMu0>!_98<$<Q(MM)~e}
zK{vOWjFO#;?@6cIs@mD2g!42It$4qH)zimzQd6QGZE9gdz}HL8`i<lFLbqz6Gh@Q(
z)p$P9ZSrSXOD=stkTB*j2UCKs5A!S-q77!b%hz15cMPz$MBd<YcrXmwLs%+R6ozQw
z4s^FaJ%1g+VJ-G9eD|x;z`XeZt+~0?x~_>e4dbt(;`4H%MmI(~I&$Is7h+C+IrcYM
z_@*holMC{KjlwVdT)j}pe{zMN<--0Tdo-C>04Po&7p`8ua+aY!`bdAIubV8w1>uSG
zAU~cvNGAVek-|<+szP2-ti6WJMSfB!tykY9@Q`;XPEja6USw7i>W_5s_eXglT!Os(
zeC2}4X<gj>T#<h&o&OhpfQkd~dqG7m;UD&0UYY)k`bWs0Re!r@Az$Rk{zGN`9!1ev
z-;9E?Ci{0<2mO!3D7x#LQD6~d|Ah+scIxkR*k5?^rJC&jQe}Ui{X6dY1H4XtyWdOx
znTh^<{=d2Cj}+oGzhtKWRRg6zf0z~Hue<f<zy06+`U8(8<A2e;e-}V`wG`3)?;ib;
bfQ9Kt$3jhM=_osg$iECK0KlBQ2LSvJH1AWL

literal 0
HcmV?d00001

diff --git a/core/tests/swfs/avm2/string_char_at/test.swf b/core/tests/swfs/avm2/string_char_at/test.swf
new file mode 100644
index 0000000000000000000000000000000000000000..d737db3cf3bd2182a830583d6ae934c9f1b39876
GIT binary patch
literal 1288
zcmV+j1^4<xS5qr;2><|ioUK*ObK67|-_?gD`6IUTAv;c-uexpAG`5n^q_u%GO`0|>
zZJ0@z>A{&;w%4}6mR(5+X)lltFboU~9Lohxw3i+@bLhVi4$L$&oX8)5!--pXYblOX
z9JsJ!@BV(j_xA1E-6v@W@tX+we?TaV(Na)E2rV*4M@Kh82n`1iicQ6K)?>@&?Dk##
z&f}%I_ugGBJX~L&o!g#HqL+Oh@W*H^PjoUeh0x31KSe4)3!nt_+;>lDJDf+&_SgK=
zpI<yU{OymA?jdQNm{yW@=Pl?qixo9>Pu28wtx77IPLeIPXsA^(HSr%_?J7sZx>j@V
zle{G!dwAPDd?1+RL_ss_74?yHuePm`#fnz%>ln{vr?9$|%9P3vGbPO`Z{-sCS~X*A
z6^j)zX_yYm<ZA}W&>&{U{IF<d)a~kY#<UDgFKy<_s<EkB=`>9*p_*=IjLlpfEn8MS
zl}xIIT8_}j$%VC<<g}v9CUaX_#nN=%GSocjOD4zET)sexrLhE!w_uIO(}E+pY(?(i
zG!;*WJIRSN4OimnPJ!m)=}-rG@{Bn5)%)=@3;j^XMdq%Ni5cZ;JRR*|UeSx1u33-b
zY4I3#iZXfPN6iPjPY!lJIoSQ|VE6Nb-7nft!2g<U7~J<i-T(U4Pp@7;|9t<;SI^r0
z1Fsv$VM62kZ=e7E@mD9qGkf^4HB*VF`_J_9Lx^_I=yAm*+AA*QR6P?@Ja$cNSz5*H
zvCCG?=ZR@*IjsV_J}zZqeqhz=UYilas2S!l*(SPWb~$9nB8IM3oM}ZUE@GH&o0Ukd
z>a0<!)N*P?d#qYoP50PZl@v5pvawDqUkfD)M%9U5hf;@fEwyM3mLP`XYpT_H8zZ`T
zlBW5{v`E#-#DYA#PGADgCD=xZUV>8+ZDmVy@@t-vliyCY5<2yer&<qr?`eGvQnpC!
zw76uC_B&*;rdx11#27y9w4%e=sd-D=Cbr|izXTa<zl_vPI#9c6<;%qAQVWG;dgE((
zL#tco&M1m@=6@}O@6>9+f8-{2-jd7S{;mJ#-Ilo|<1jA^vK01&1imYTML+N1FN))G
zT)ZSt$d|=QIUy%SMV^wU<r(n}@rpPr&dFEhYjR3V%WukWiEl?dk@?8=$U@{sWHGYD
zW6WVelvpfC7u+7qx+Jf!i}MG9-95d1awyy%85oQX4UdeD@#kXaFI*gt_X?O7uuEV?
zfpZHkuf$`?#Yh2G>S3h_D@9p}=cJpQ<mH6GErGi&a4Q0LN8s)X_V<fH_DKIM{gBz1
z!HmQJU^$UTJmxVqu!vzGMTA_K<uDcyhLPP<Zow4LdH0^Ow}K9RjZsh-mci^kv!?)O
zHe6Xo$qElpw2XoC8{*~Qs)!pd0Nu+HqF4ajOMytm7+#hzWfHJH3fxpq9?KqJG6mkI
z%s8?SScrnIW)Q)V{lLN$1e)@ZBL{)?Q_xN2tlN=$fDKU4+l<XRav!ik3go7@$B{$8
zhA0Tz@;8p&4|JG<2!N5+eg=SzQZNW$tR+W*ougm~KrDtFc^KGv3Pu3nro1fTC%^u3
z8?FOm$!#A$+=koZhqJ!WU^l#XyeQt_K;~JH<>swy_zssF5MZy^wd!LU3|L)onbO3b
yLJ++izmg3o*`Si`R<b=xmV@5|9JO1SJ$$DThAHzs5vNu<KDX#PSpEhM7uHz(d4<6M

literal 0
HcmV?d00001