avm2: Implement NetConnection.connect with a null `command`

core/src/avm2/globals/flash/net.rs

@@ -4,6 +4,7 @@ use crate::avm2::object::TObject;
 use crate::avm2::{Activation, Error, Object, Value};
 
 pub mod local_connection;
+pub mod net_connection;
 pub mod net_stream;
 pub mod object_encoding;
 pub mod shared_object;

core/src/avm2/globals/flash/net/NetConnection.as

@@ -10,9 +10,7 @@ package flash.net {
         public var objectEncoding:uint = NetConnection.defaultObjectEncoding;
 
 
-        public function connect(command:String, ... arguments):void {
+        public native function connect(command:String, ... arguments):void;
-            stub_method("flash.net.NetConnection", "connect");
-        }
 
         public function addHeader(operation:String, mustUnderstand:Boolean = false, param:Object = null):void {
             stub_method("flash.net.NetConnection", "addHeader");

core/src/avm2/globals/flash/net/net_connection.rs

@@ -0,0 +1,31 @@
+use crate::{
+    avm2::{Activation, Avm2, Error, EventObject, Object, Value},
+    avm2_stub_method,
+};
+
+pub fn connect<'gc>(
+    activation: &mut Activation<'_, 'gc>,
+    this: Option<Object<'gc>>,
+    args: &[Value<'gc>],
+) -> Result<Value<'gc>, Error<'gc>> {
+    let this = this.unwrap();
+    if let Value::Null = args[0] {
+        let event = EventObject::net_status_event(
+            activation,
+            "netStatus",
+            &[
+                ("code", "NetConnection.Connect.Success"),
+                ("level", "status"),
+            ],
+        );
+        Avm2::dispatch_event(&mut activation.context, event, this);
+        return Ok(Value::Undefined);
+    }
+    avm2_stub_method!(
+        activation,
+        "flash.net.NetConnection",
+        "connect",
+        "with non-null command"
+    );
+    Ok(Value::Undefined)
+}

tests/tests/swfs/avm2/netstream_connect/Test.as

@@ -0,0 +1,17 @@
+package {
+	import flash.net.NetConnection;
+
+	public class Test {
+		public function Test() {
+			var connection = new NetConnection();
+			connection.addEventListener("netStatus", function(e) {
+				trace("Event: " + e);
+				trace("Code: " + e.info.code);
+				trace("Level: " + e.info.level);
+			});
+			trace("Calling connect");
+			connection.connect(null);
+			trace("Called connect");
+		}
+	}
+}

tests/tests/swfs/avm2/netstream_connect/output.txt

@@ -0,0 +1,5 @@
+Calling connect
+Event: [NetStatusEvent type="netStatus" bubbles=false cancelable=false eventPhase=2 info=[object Object]]
+Code: NetConnection.Connect.Success
+Level: status
+Called connect

tests/tests/swfs/avm2/netstream_connect/test.toml

@@ -0,0 +1 @@
+num_ticks = 1