liangsheng8708
/
ruffle
mirror of https://mirror.ghproxy.com/https://github.com/ruffle-rs/ruffle.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

web: Avoid any issues with parseInt("0...")

This commit is contained in:
Nathan Adams 2020-05-18 01:00:38 +02:00
parent 4ab15855ff
commit b0b54b59f9
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/packages/core/src/version.js
View File

@ -33,16 +33,16 @@ exports.Version = class Version {
version_split = pr_split[0].split("."),
version = [];
version.push(parseInt(version_split[0]));
version.push(parseInt(version_split[0], 10));
if (version_split[1] != undefined) {
version.push(parseInt(version_split[1]));
version.push(parseInt(version_split[1], 10));
} else {
version.push(0);
}
if (version_split[2] != undefined) {
version.push(parseInt(version_split[2]));
version.push(parseInt(version_split[2], 10));
} else {
version.push(0);
}
@ -147,11 +147,13 @@ exports.Version = class Version {
is_numeric.test(fver.pr_ident[i])
) {
if (
parseInt(this.pr_ident[i]) > parseInt(fver.pr_ident[i])
parseInt(this.pr_ident[i], 10) >
parseInt(fver.pr_ident[i], 10)
) {
return true;
} else if (
parseInt(this.pr_ident[i]) < parseInt(fver.pr_ident[i])
parseInt(this.pr_ident[i], 10) <
parseInt(fver.pr_ident[i], 10)
) {
return false;
}

5
web/packages/core/test/version.js
View File

@ -13,6 +13,7 @@ const testMatrix = [
"1-rc.1",
"1-beta.11",
"1-beta.2",
"1-beta.01",
"1-beta",
"1-alpha.beta",
"1-alpha.1",
@ -34,6 +35,10 @@ describe("Version", function () {
Version.from_semver("1.2.3"),
new Version(1, 2, 3, undefined, undefined)
);
assert.deepEqual(
Version.from_semver("1.09.3"),
new Version(1, 9, 3, undefined, undefined)
);
assert.deepEqual(
Version.from_semver("1.2.3-pr"),
new Version(1, 2, 3, ["pr"], undefined)