web: Avoid any issues with parseInt("0...")
This commit is contained in:
parent
4ab15855ff
commit
b0b54b59f9
|
@ -33,16 +33,16 @@ exports.Version = class Version {
|
|||
version_split = pr_split[0].split("."),
|
||||
version = [];
|
||||
|
||||
version.push(parseInt(version_split[0]));
|
||||
version.push(parseInt(version_split[0], 10));
|
||||
|
||||
if (version_split[1] != undefined) {
|
||||
version.push(parseInt(version_split[1]));
|
||||
version.push(parseInt(version_split[1], 10));
|
||||
} else {
|
||||
version.push(0);
|
||||
}
|
||||
|
||||
if (version_split[2] != undefined) {
|
||||
version.push(parseInt(version_split[2]));
|
||||
version.push(parseInt(version_split[2], 10));
|
||||
} else {
|
||||
version.push(0);
|
||||
}
|
||||
|
@ -147,11 +147,13 @@ exports.Version = class Version {
|
|||
is_numeric.test(fver.pr_ident[i])
|
||||
) {
|
||||
if (
|
||||
parseInt(this.pr_ident[i]) > parseInt(fver.pr_ident[i])
|
||||
parseInt(this.pr_ident[i], 10) >
|
||||
parseInt(fver.pr_ident[i], 10)
|
||||
) {
|
||||
return true;
|
||||
} else if (
|
||||
parseInt(this.pr_ident[i]) < parseInt(fver.pr_ident[i])
|
||||
parseInt(this.pr_ident[i], 10) <
|
||||
parseInt(fver.pr_ident[i], 10)
|
||||
) {
|
||||
return false;
|
||||
}
|
||||
|
|
|
@ -13,6 +13,7 @@ const testMatrix = [
|
|||
"1-rc.1",
|
||||
"1-beta.11",
|
||||
"1-beta.2",
|
||||
"1-beta.01",
|
||||
"1-beta",
|
||||
"1-alpha.beta",
|
||||
"1-alpha.1",
|
||||
|
@ -34,6 +35,10 @@ describe("Version", function () {
|
|||
Version.from_semver("1.2.3"),
|
||||
new Version(1, 2, 3, undefined, undefined)
|
||||
);
|
||||
assert.deepEqual(
|
||||
Version.from_semver("1.09.3"),
|
||||
new Version(1, 9, 3, undefined, undefined)
|
||||
);
|
||||
assert.deepEqual(
|
||||
Version.from_semver("1.2.3-pr"),
|
||||
new Version(1, 2, 3, ["pr"], undefined)
|
||||
|
|
Loading…
Reference in New Issue