From a2968e6ecb82a1a284f53c02068dde1456d77513 Mon Sep 17 00:00:00 2001 From: Daniel Jacobs Date: Wed, 3 Aug 2022 13:47:55 -0400 Subject: [PATCH] demo: Use switch statement instead of branches --- web/packages/demo/www/index.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/web/packages/demo/www/index.js b/web/packages/demo/www/index.js index 9eb6fe77a..8abb24dc1 100644 --- a/web/packages/demo/www/index.js +++ b/web/packages/demo/www/index.js @@ -99,19 +99,21 @@ function load(options) { for (const [key, value] of Object.entries(this.metadata)) { const metadataElement = document.getElementById(key); if (metadataElement) { - if (key === "backgroundColor") { - metadataElement.value = value ?? "#FFFFFF"; - } else { - if (key === "swfVersion") { + switch (key) { + case "backgroundColor": + metadataElement.value = value ?? "#FFFFFF"; + break; + case "uncompressedLength": + metadataElement.textContent = `${value >> 10}Kb`; + break; + case "swfVersion": document.getElementById( "flashVersion" ).textContent = swfToFlashVersion[value]; - } - if (key === "uncompressedLength") { - metadataElement.textContent = `${value >> 10}Kb`; - } else { + // falls through and executes the default case as well + default: metadataElement.textContent = value; - } + break; } } }