From 9cab16eb6897acf5c27e1082dbf940a5d3586a53 Mon Sep 17 00:00:00 2001 From: sleepycatcoding <131554884+sleepycatcoding@users.noreply.github.com> Date: Tue, 2 Apr 2024 19:27:25 +0300 Subject: [PATCH] desktop: use location instead of url URL might be a bit misleading when you can also use local files as bookmarks. --- desktop/assets/texts/en-US/bookmarks_dialog.ftl | 1 - desktop/src/gui/bookmarks_dialog.rs | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/desktop/assets/texts/en-US/bookmarks_dialog.ftl b/desktop/assets/texts/en-US/bookmarks_dialog.ftl index 8a6a99541..6f1bc072d 100644 --- a/desktop/assets/texts/en-US/bookmarks_dialog.ftl +++ b/desktop/assets/texts/en-US/bookmarks_dialog.ftl @@ -3,6 +3,5 @@ bookmark-dialog-add = Add Bookmark bookmarks-dialog-name = Name bookmarks-dialog-location = Location -bookmarks-dialog-url = URL bookmarks-dialog-no-bookmarks = There are no bookmarks right now bookmarks-dialog-not-selected = Nothing to show \ No newline at end of file diff --git a/desktop/src/gui/bookmarks_dialog.rs b/desktop/src/gui/bookmarks_dialog.rs index 07c170866..3b19d6f71 100644 --- a/desktop/src/gui/bookmarks_dialog.rs +++ b/desktop/src/gui/bookmarks_dialog.rs @@ -46,7 +46,7 @@ impl BookmarkAddDialog { ui.text_edit_singleline(&mut self.name); ui.end_row(); - ui.label(text(locale, "bookmarks-dialog-url")); + ui.label(text(locale, "bookmarks-dialog-location")); self.url.ui(locale, ui); ui.end_row(); }); @@ -234,7 +234,7 @@ impl BookmarksDialog { let previous_url = bookmark.url.value().cloned(); - ui.label(text(locale, "bookmarks-dialog-url")); + ui.label(text(locale, "bookmarks-dialog-location")); let current_url = bookmark.url.ui(locale, ui).value(); // TOOD: Change the UrlOrPathField widget to return a response instead, so we can update when we lose the focus, removes the need to clone every redraw.