From 72965b3689db59e00613a3d8fc8b8e33379f0da6 Mon Sep 17 00:00:00 2001
From: Tom Schuster <evilpies@gmail.com>
Date: Sun, 29 Oct 2023 16:30:14 +0100
Subject: [PATCH] amv2: Implement flash.xml.XMLNode removeNode

---
 core/src/avm2/globals/flash/xml/XMLNode.as    |  27 +++++++-
 .../swfs/avm2/flash_xml_removeNode/Test.as    |  49 ++++++++++++++
 .../swfs/avm2/flash_xml_removeNode/output.txt |  60 ++++++++++++++++++
 .../swfs/avm2/flash_xml_removeNode/test.swf   | Bin 0 -> 1410 bytes
 .../swfs/avm2/flash_xml_removeNode/test.toml  |   1 +
 5 files changed, 134 insertions(+), 3 deletions(-)
 create mode 100644 tests/tests/swfs/avm2/flash_xml_removeNode/Test.as
 create mode 100644 tests/tests/swfs/avm2/flash_xml_removeNode/output.txt
 create mode 100644 tests/tests/swfs/avm2/flash_xml_removeNode/test.swf
 create mode 100644 tests/tests/swfs/avm2/flash_xml_removeNode/test.toml

diff --git a/core/src/avm2/globals/flash/xml/XMLNode.as b/core/src/avm2/globals/flash/xml/XMLNode.as
index bbf13f474..51a13028d 100644
--- a/core/src/avm2/globals/flash/xml/XMLNode.as
+++ b/core/src/avm2/globals/flash/xml/XMLNode.as
@@ -60,9 +60,30 @@ package flash.xml
             return clone;
         }
 
-        public function removeNode() : void
-        {
-            stub_method("flash.xml.XMLNode", "removeNode");
+        public function removeNode(): void {
+            if (parentNode) {
+                if (parentNode.firstChild === this) {
+                    parentNode.firstChild = nextSibling;
+                }
+                if (parentNode.lastChild === this) {
+                    parentNode.lastChild = previousSibling;
+                }
+                var index = parentNode.childNodes.indexOf(this);
+                if (index > -1) {
+                    parentNode.childNodes.removeAt(index);
+                }
+            }
+
+            if (previousSibling) {
+                previousSibling.nextSibling = nextSibling;
+            }
+            if (nextSibling) {
+                nextSibling.previousSibling = previousSibling;
+            }
+
+            parentNode = null;
+            previousSibling = null;
+            nextSibling = null;
         }
 
         public function insertBefore(node: XMLNode, before: XMLNode = null): void {
diff --git a/tests/tests/swfs/avm2/flash_xml_removeNode/Test.as b/tests/tests/swfs/avm2/flash_xml_removeNode/Test.as
new file mode 100644
index 000000000..4af1409f9
--- /dev/null
+++ b/tests/tests/swfs/avm2/flash_xml_removeNode/Test.as
@@ -0,0 +1,49 @@
+package {
+  import flash.display.Sprite;
+  public class Test extends Sprite { }
+}
+
+import flash.xml.XMLDocument;
+
+trace("///");
+var doc = new XMLDocument('<parent><child hello="world">a single child</child></parent>');
+trace("doc: " + doc);
+var single = doc.firstChild.firstChild;
+trace("single: " + single);
+single.removeNode();
+trace("/// After removal");
+trace("doc: " + doc);
+trace("single: " + single);
+trace("single.parentNode: " + single.parentNode);
+trace("single.nextSibling: " + single.nextSibling);
+trace("single.previousSibling: " + single.previousSibling);
+
+function test(index) {
+  var doc = new XMLDocument('<parent><first/><second/><last/></parent>')
+  trace("///")
+  trace("doc: " + doc);
+  var root = doc.firstChild;
+  var childNodes = root.childNodes;
+  var child = childNodes[index];
+  trace("root.childNodes[" + index + "]: " + child);
+  child.removeNode();
+  trace("/// After removal");
+  trace("doc: " + doc);
+  trace("child: " + child);
+  trace("child.parentNode: " + child.parentNode);
+  trace("child.nextSibling: " + child.nextSibling);
+  trace("child.previousSibling: " + child.previousSibling);
+
+  trace("root.firstChild: " + root.firstChild);
+  trace("root.lastChild: " + root.lastChild);
+
+  for (var i = 0; i < childNodes.length; i++) {
+    trace("childNodes[" + i + "]: " + childNodes[i]);
+    trace("childNodes[" + i + "].previousSibling: " + childNodes[i].previousSibling);
+    trace("childNodes[" + i + "].nextSibling: " + childNodes[i].nextSibling);
+  }
+}
+
+test(0);
+test(1);
+test(2);
diff --git a/tests/tests/swfs/avm2/flash_xml_removeNode/output.txt b/tests/tests/swfs/avm2/flash_xml_removeNode/output.txt
new file mode 100644
index 000000000..825f7dd74
--- /dev/null
+++ b/tests/tests/swfs/avm2/flash_xml_removeNode/output.txt
@@ -0,0 +1,60 @@
+///
+doc: <parent><child hello="world">a single child</child></parent>
+single: <child hello="world">a single child</child>
+/// After removal
+doc: <parent />
+single: <child hello="world">a single child</child>
+single.parentNode: null
+single.nextSibling: null
+single.previousSibling: null
+///
+doc: <parent><first /><second /><last /></parent>
+root.childNodes[0]: <first />
+/// After removal
+doc: <parent><second /><last /></parent>
+child: <first />
+child.parentNode: null
+child.nextSibling: null
+child.previousSibling: null
+root.firstChild: <second />
+root.lastChild: <last />
+childNodes[0]: <second />
+childNodes[0].previousSibling: null
+childNodes[0].nextSibling: <last />
+childNodes[1]: <last />
+childNodes[1].previousSibling: <second />
+childNodes[1].nextSibling: null
+///
+doc: <parent><first /><second /><last /></parent>
+root.childNodes[1]: <second />
+/// After removal
+doc: <parent><first /><last /></parent>
+child: <second />
+child.parentNode: null
+child.nextSibling: null
+child.previousSibling: null
+root.firstChild: <first />
+root.lastChild: <last />
+childNodes[0]: <first />
+childNodes[0].previousSibling: null
+childNodes[0].nextSibling: <last />
+childNodes[1]: <last />
+childNodes[1].previousSibling: <first />
+childNodes[1].nextSibling: null
+///
+doc: <parent><first /><second /><last /></parent>
+root.childNodes[2]: <last />
+/// After removal
+doc: <parent><first /><second /></parent>
+child: <last />
+child.parentNode: null
+child.nextSibling: null
+child.previousSibling: null
+root.firstChild: <first />
+root.lastChild: <second />
+childNodes[0]: <first />
+childNodes[0].previousSibling: null
+childNodes[0].nextSibling: <second />
+childNodes[1]: <second />
+childNodes[1].previousSibling: <first />
+childNodes[1].nextSibling: null
diff --git a/tests/tests/swfs/avm2/flash_xml_removeNode/test.swf b/tests/tests/swfs/avm2/flash_xml_removeNode/test.swf
new file mode 100644
index 0000000000000000000000000000000000000000..d5dfc5491a382d200cbf2a128bd26ff32958aaa7
GIT binary patch
literal 1410
zcmV-|1%3KMS5qeG2mk<h0fkjhQ`=S$e@~Jn%NT59Fc9)bArK(JmN5w}isOO7rA?;^
zozPA*&3HVr^n}&Ol1Gv;nRccfu08b|<k0D*AEKuo+7n5p?Y*bma6bXv_he(-OFg5f
z{q6pC-@e^_@-Y(rMrh(Egk~|SX66t=-)7%ogv!2YX-}(r%5lqa0}ar_<z^VRHC63)
zyM^vX!SfH*^{uTfwOCS1r93e5!Am#PkMnMDYq`P#R7qg?c005^SD^v*hSv!nE-&|^
zn#M)YcE@*ENYhY>Lt4ZQ19iQy4uMQVvpm10hZViuc5FkZ;nd@N(DaNKUHypUEk_TU
zWpzlTKA{~tq_Wf2jV4j{9CEDe4BZ(yVo<I*%(K!zr3D@Zoq4mon8#%v^=o$;jvX|K
zKiKEMv%;?K!-ihRHCd+2aY&?YhEMd+`(LL4jk-9xd)UzrNrkxe&ktD43l%$o9+Jww
z5h|svHKkN6ZAAG}ZCRzIztoDp2D)286Y0*}ll}asI|m0}>_4rd(-e%r$gi4y$CuGA
zcYc2UWr7Ej2#=6{@!JNB2|_<_&VTbgNWUgNBSDCMnfe;+)WTpI6)343vt5%M^QLDA
zzUPGrqiH+l6A$VcV<NU6t4*&()X;0GZQuKf7|?&eV?i6#5CRANHRxJ_svosVDr<Tj
z#<T8|mUl#Gv<DC9t_3|9d-nK~s%LcQ9LbDX0Oo4B4ZU&0O4+jgAXF>mfEb=@f&ddl
zvDzoZLSHus;#F0RLDHI%U>>_PZFW%DW3jY#vp+1l=`~2ffZTTuHq=tFxT!WewiDWJ
znjW_>JnnP82Em3IXJ7|q#|nwBFs1HDjI1e>>|KZwqK5;&A;?BnmmG%&HVmPAs3~KY
z&`jUkCr7r|2`)IP_NXSq@*5sbQ=*J%J$C77HATLV$5>F-w&&Se;Xk1?B~>e2N<mXZ
zhq#AfGu3Yj6ilPN6eyPIqS9qN>W^s$ZAX789<+TsB;tO9&OqveBj{HZOnM0S*iS}W
zLbbs-)q_h!%{+3Uin<ZnM<mkZM(n#De4K2T_yWzLd@%~_OiGhDj`wh(>-mnkP|=kD
zD(Vo08Othr4W}a>Sv4ga2_sFK>gz@-F*_iRR$o(Q>h(jf9(r|?Shj1^Pg@;wY4dF_
z;O=ko>l-C8^5skS?#K5!E*#Kv<(!;L#?tXjY$>-qyOg`j@f<JANH{KWV{!`10-ne6
z6qaYPd<Dx_v3vu|x3I)5N#csctxEAblDH;`c}XltyejdW#BWL50|9RC;&-ql;nv=U
zCyDs`c=J7Y-iJrS$#Gdi99(eB3&|?H(9|{u7amV<!?yu*Sy9L#0SOYuzjJ38qv<ou
z;oKSKxw$he@K?@oOqf5zVr=Cfsh6wawZz95pZwXIsc~!LdmLWv&4M)X<`t9Y-dOy}
zU%e}DE#brvdh-q8wG}%tV!f+Cntc6gE&Hkwi>TKcu{{y3_O63vnmOON6i5L%H=y1G
zFw=-xQslV+a1LNRg0}$91C%4U1n}Bhi;vK4K-b?|i3qJMq7y?*KSfCHt%5~qh%6<c
zAzJ;k?hMp7Up1I|5clrDurM(6_g`s<KS0!m*buC-=^xL}d-)G(g>hWwPm3UO7|V&o
zY4P+Cf*O`U!}A=DpKzx|z&t^<32UNQOIfL6Ep4TXwTzW1)+VjVVr|?SXUj8mjs2QQ
z@R%lO8#S{a#UZDt2{Lr12%RzSwzysb)Dxz|MTZ^($>J>@Onfg1rghWlS7#g~)`SUA
zM@>kL_@+nb89*g)88l)N@CL>GN@M}wqqyG+wU%8(ds&!~B1o7?>mYF;o&53oqc{w%
QoP{O&^VtUBUsGzH%fV8x^Z)<=

literal 0
HcmV?d00001

diff --git a/tests/tests/swfs/avm2/flash_xml_removeNode/test.toml b/tests/tests/swfs/avm2/flash_xml_removeNode/test.toml
new file mode 100644
index 000000000..dbee897f5
--- /dev/null
+++ b/tests/tests/swfs/avm2/flash_xml_removeNode/test.toml
@@ -0,0 +1 @@
+num_frames = 1