From 696514862ddc8d958573aa8506940b11ca4cd03b Mon Sep 17 00:00:00 2001
From: relrelb <relrelbachar@gmail.com>
Date: Fri, 2 Sep 2022 11:27:34 +0300
Subject: [PATCH] extension: Migrate to TypeScript 4.8

Per https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#unconstrained-generics-no-longer-assignable-to,
`Object.entries()` no longer accepts nullable objects.
The suggested fix is to add a `T extends {}` constraint, but that's
disallowed by https://typescript-eslint.io/rules/ban-types/. So instead
change the parameter types from `T` to `NonNull<T>`.
---
 web/packages/extension/src/popup.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web/packages/extension/src/popup.ts b/web/packages/extension/src/popup.ts
index 183910d26..ea5d9b62f 100644
--- a/web/packages/extension/src/popup.ts
+++ b/web/packages/extension/src/popup.ts
@@ -81,7 +81,7 @@ async function queryTabStatus(
     optionsChanged();
 }
 
-function objectsEqual<T>(x: T, y: T) {
+function objectsEqual<T>(x: NonNullable<T>, y: NonNullable<T>) {
     for (const [key, value] of Object.entries(x)) {
         if (y[key as keyof T] !== value) {
             return false;